add togglable QR code to wallet address component #1582

Merged

daovist merged 2 commits from qr-code into master

2018-06-14 08:25:05 +02:00

daovist commented

2018-06-12 15:25:07 +02:00

(Migrated from github.com)

No description provided.

tzarebczan commented

2018-06-12 17:48:55 +02:00

(Migrated from github.com)

I'm not crazy about how the button looks on both light and dark themes. Maybe @seanyesmunt can work on styling it better.

Also, doesn't work in dark mode - looks like some of the background is seeping through and adding some extra tiny lines to the QR.

I'm not crazy about how the button looks on both light and dark themes. Maybe @seanyesmunt can work on styling it better. Also, doesn't work in dark mode - looks like some of the background is seeping through and adding some extra tiny lines to the QR. ![qr code](https://user-images.githubusercontent.com/8120721/41301661-92070cbc-6e36-11e8-8ee8-9c97a63a85a4.jpg)

neb-b commented

2018-06-12 18:33:00 +02:00

(Migrated from github.com)

I agree @tzarebczan. There was some styling to ensure the qr code had a white border so that it worked with dark mode. Maybe we lost that? This should probably use the button="link" style.

I agree @tzarebczan. There was some styling to ensure the qr code had a white border so that it worked with dark mode. Maybe we lost that? This should probably use the `button="link"` style.

daovist commented

2018-06-12 22:07:47 +02:00

(Migrated from github.com)

updated to button="link"

updated to `button="link"`

neb-b (Migrated from github.com) requested changes 2018-06-13 18:35:24 +02:00

neb-b (Migrated from github.com) left a comment

Seeing this with the error

Failed prop type: Invalid prop `size` of type `string` supplied to `QRCodeCanvas`, expected `number`.
in QRCodeCanvas (created by QRCode)

Not sure why it's overlapping. I also think we can make this a little bit smaller.

<img width="200" alt="screen shot 2018-06-13 at 12 33 31 pm" src="https://user-images.githubusercontent.com/16882830/41364941-10c5bd08-6f06-11e8-9415-305bf5f787c5.png"> Seeing this with the error ``` Failed prop type: Invalid prop `size` of type `string` supplied to `QRCodeCanvas`, expected `number`. in QRCodeCanvas (created by QRCode) ``` Not sure why it's overlapping. I also think we can make this a little bit smaller.

tzarebczan commented

2018-06-14 06:22:02 +02:00

(Migrated from github.com)

Working on dark mode now!

neb-b (Migrated from github.com) approved these changes 2018-06-14 08:24:49 +02:00