handle fetching state on downloads and publishes pages #1593

Merged
daovist merged 5 commits from downloads-pending into master 2018-07-18 20:56:32 +02:00
daovist commented 2018-06-14 00:08:17 +02:00 (Migrated from github.com)

This adds a fetching prop to each of the two pages, selectIsFetchingFileList for downloads and selectIsFetchingClaimListMine for publishes.

This one is hard to test because you need to download lots of content so that your downloads page takes a while to load. I haven't gotten there with publishes but am making this PR for @tzarebczan and @seanyesmunt to take a look at.

#1283

This adds a `fetching` prop to each of the two pages, `selectIsFetchingFileList` for downloads and `selectIsFetchingClaimListMine` for publishes. This one is hard to test because you need to download lots of content so that your downloads page takes a while to load. I haven't gotten there with publishes but am making this PR for @tzarebczan and @seanyesmunt to take a look at. #1283
neb-b commented 2018-06-19 08:29:44 +02:00 (Migrated from github.com)

We should use the loading prop on the <Page /> component here instead. I know it's a little funky since it is doing some special stuff for the subscription page. I'm planning on working on that soon so we can add this after that component is cleaned up.

We should use the `loading` prop on the `<Page />` component here instead. I know it's a little funky since it is doing some special stuff for the subscription page. I'm planning on working on that soon so we can add this after that component is cleaned up.
neb-b commented 2018-07-09 06:33:17 +02:00 (Migrated from github.com)

@daovist Sorry this has been sitting for so long. Hoping to improve the subscriptions page so we can use this on the publishes/downloads page.

@daovist Sorry this has been sitting for so long. Hoping to improve the subscriptions page so we can use this on the publishes/downloads page.
neb-b (Migrated from github.com) reviewed 2018-07-16 22:22:49 +02:00
@ -92,4 +92,1 @@
"danger": "^3.6.0",
"danger-plugin-eslint": "^0.1.0",
"danger-plugin-yarn": "^1.3.0",
"decompress": "^4.2.0",
neb-b (Migrated from github.com) commented 2018-07-16 22:22:48 +02:00

This was causing issues with Flow for me. We aren't using danger-ci atm so we can remove it (hopefully just for now. it would be nice to get it back)

This was causing issues with Flow for me. We aren't using danger-ci atm so we can remove it (hopefully just for now. it would be nice to get it back)
skhameneh (Migrated from github.com) approved these changes 2018-07-18 15:32:26 +02:00
skhameneh (Migrated from github.com) left a comment

Minor comment on handling timeouts

Minor comment on handling timeouts
skhameneh (Migrated from github.com) commented 2018-07-18 15:30:52 +02:00

This will only set the handle to null, you'll want to use clearTimeout in some parts of the flow.

This will only set the handle to null, you'll want to use `clearTimeout` in some parts of the flow.
neb-b (Migrated from github.com) reviewed 2018-07-18 18:49:20 +02:00
neb-b (Migrated from github.com) commented 2018-07-18 18:49:20 +02:00

Whoops

Whoops
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1593
No description provided.