handle fetching state on downloads and publishes pages #1593
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#1593
Loading…
Reference in a new issue
No description provided.
Delete branch "downloads-pending"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This adds a
fetching
prop to each of the two pages,selectIsFetchingFileList
for downloads andselectIsFetchingClaimListMine
for publishes.This one is hard to test because you need to download lots of content so that your downloads page takes a while to load. I haven't gotten there with publishes but am making this PR for @tzarebczan and @seanyesmunt to take a look at.
#1283
We should use the
loading
prop on the<Page />
component here instead. I know it's a little funky since it is doing some special stuff for the subscription page. I'm planning on working on that soon so we can add this after that component is cleaned up.@daovist Sorry this has been sitting for so long. Hoping to improve the subscriptions page so we can use this on the publishes/downloads page.
@ -92,4 +92,1 @@
"danger": "^3.6.0",
"danger-plugin-eslint": "^0.1.0",
"danger-plugin-yarn": "^1.3.0",
"decompress": "^4.2.0",
This was causing issues with Flow for me. We aren't using danger-ci atm so we can remove it (hopefully just for now. it would be nice to get it back)
Minor comment on handling timeouts
This will only set the handle to null, you'll want to use
clearTimeout
in some parts of the flow.Whoops