LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

i18n Support #160

Merged
MaxiBoether merged 68 commits from i18n into master 2017-06-05 17:34:23 +02:00
Conversation 4 Commits 68 Files changed 48 +420 -377
MaxiBoether commented 2017-05-30 15:04:09 +02:00 (Migrated from github.com)
Copy link

Please excuse some double commits, but it seems like a rebase did go wrong. We doublechecked to make sure every String is translateable, please tell us if we missed a String. There is also a sample translation added that just adds RS_ to every string. Users are able to change the language in the options.
I will also try and create a German translation as soon as this is merged into master. intnick will probably make a Serbian translation.

Please excuse some double commits, but it seems like a rebase did go wrong. We doublechecked to make sure every String is translateable, please tell us if we missed a String. There is also a sample translation added that just adds RS_ to every string. Users are able to change the language in the options. I will also try and create a German translation as soon as this is merged into master. intnick will probably make a Serbian translation.
🎉 2
kauffj (Migrated from github.com) reviewed 2017-05-31 02:01:19 +02:00
ui/js/rewards.js
kauffj (Migrated from github.com) commented 2017-05-31 02:01:19 +02:00
Copy link

Tick marks are only used around interpolated strings. If interpolation is being dropped, please switch to double quotes.

Tick marks are only used around interpolated strings. If interpolation is being dropped, please switch to double quotes.
kauffj (Migrated from github.com) reviewed 2017-05-31 02:02:38 +02:00
ui/js/selectors/app.js
@ -38,35 +38,28 @@ export const selectPageTitle = createSelector(
selectCurrentParams,
kauffj (Migrated from github.com) commented 2017-05-31 02:02:38 +02:00
Copy link

This code was correct. Yes, it means it cannot easily be translated. For tricky ones like this, just make a note and we'll figure out how to resolve them.

This code was correct. Yes, it means it cannot easily be translated. For tricky ones like this, just make a note and we'll figure out how to resolve them.
kauffj (Migrated from github.com) reviewed 2017-05-31 02:05:49 +02:00
ui/watch.bat
kauffj (Migrated from github.com) commented 2017-05-31 02:05:49 +02:00
Copy link

Please update the README and add a heading titled "Internationalization" that explains a bit about this, and anything else that would be relevant to set up or programmers new to the repo. Should be a couple paragraphs tops, and possibly just a sentence or two.

Please update the README and add a heading titled "Internationalization" that explains a bit about this, and anything else that would be relevant to set up or programmers new to the repo. Should be a couple paragraphs tops, and possibly just a sentence or two.
kauffj (Migrated from github.com) reviewed 2017-05-31 02:06:52 +02:00
ui/js/page/help/view.jsx
kauffj (Migrated from github.com) commented 2017-05-31 02:06:52 +02:00
Copy link

Misstructured call?

Misstructured call?
kauffj (Migrated from github.com) reviewed 2017-05-31 02:07:59 +02:00
ui/js/main.js
kauffj (Migrated from github.com) commented 2017-05-31 02:07:59 +02:00
Copy link

Is this used? If not, no need to global.

Is this used? If not, no need to global.
kauffj (Migrated from github.com) reviewed 2017-05-31 02:08:34 +02:00
ui/js/main.js
kauffj (Migrated from github.com) commented 2017-05-31 02:08:34 +02:00
Copy link

This can probably be imported when needed, rather than globalled.

This can probably be imported when needed, rather than globalled.
kauffj (Migrated from github.com) reviewed 2017-05-31 02:10:13 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

Nothing too major, but a few changes I'd like. Next big piece will be figuring out how to pipe translations in and out.

Nothing too major, but a few changes I'd like. Next big piece will be figuring out how to pipe translations in and out.
kauffj commented 2017-05-31 02:10:47 +02:00 (Migrated from github.com)
Copy link

@lyoshenka might want to take a look at this one too

@lyoshenka might want to take a look at this one too
MaxiBoether (Migrated from github.com) reviewed 2017-05-31 12:31:00 +02:00
ui/js/selectors/app.js
@ -38,35 +38,28 @@ export const selectPageTitle = createSelector(
selectCurrentParams,
MaxiBoether (Migrated from github.com) commented 2017-05-31 12:31:00 +02:00
Copy link

@intnick I think you translated this, could you please take a look?

@intnick I think you translated this, could you please take a look?
MaxiBoether (Migrated from github.com) reviewed 2017-05-31 12:31:41 +02:00
ui/watch.bat
MaxiBoether (Migrated from github.com) commented 2017-05-31 12:31:41 +02:00
Copy link

Ohhh, this were my Windows compilation files. They were not supposed to be made public because most ppl are probably working with unix based systems. I am gonna remove them

Ohhh, this were my Windows compilation files. They were not supposed to be made public because most ppl are probably working with unix based systems. I am gonna remove them
MaxiBoether (Migrated from github.com) reviewed 2017-05-31 12:33:10 +02:00
ui/js/main.js
MaxiBoether (Migrated from github.com) commented 2017-05-31 12:33:10 +02:00
Copy link

@intnick can you please have a look at those?

@intnick can you please have a look at those?
MaxiBoether (Migrated from github.com) reviewed 2017-05-31 12:38:44 +02:00
ui/js/rewards.js
MaxiBoether (Migrated from github.com) commented 2017-05-31 12:38:44 +02:00
Copy link

should be fixed

should be fixed
MaxiBoether (Migrated from github.com) reviewed 2017-05-31 12:39:24 +02:00
ui/js/page/help/view.jsx
MaxiBoether (Migrated from github.com) commented 2017-05-31 12:39:24 +02:00
Copy link

should be fixed

should be fixed
intnick (Migrated from github.com) reviewed 2017-06-01 15:31:52 +02:00
ui/js/selectors/app.js
@ -38,35 +38,28 @@ export const selectPageTitle = createSelector(
selectCurrentParams,
intnick (Migrated from github.com) commented 2017-06-01 15:31:52 +02:00
Copy link

OK, do you want to return to the initial solution ? We could possibly translate the return of the function, I just found it not to be an elegant or easily readable solution so I separated them

OK, do you want to return to the initial solution ? We could possibly translate the return of the function, I just found it not to be an elegant or easily readable solution so I separated them
intnick (Migrated from github.com) reviewed 2017-06-01 15:37:50 +02:00
ui/js/main.js
intnick (Migrated from github.com) commented 2017-06-01 15:37:49 +02:00
Copy link

Yes, the translate functions are used on every page. __n is used rarely and we could use it as i18.__n() instead, though to make it equivalent and available.
I tried it first with i18n component in local scope but problems start with language switching. It wouldn't change the language strings if on the settings page we load the i18n again and do a setLanguage(language) method call. We could tell the user to restart the app, which would have been much easier for me, but I didn't like the idea of app restart if you changed the language. More than open for other suggestions ?

Yes, the translate functions are used on every page. __n is used rarely and we could use it as i18.__n() instead, though to make it equivalent and available. I tried it first with i18n component in local scope but problems start with language switching. It wouldn't change the language strings if on the settings page we load the i18n again and do a setLanguage(language) method call. We could tell the user to restart the app, which would have been much easier for me, but I didn't like the idea of app restart if you changed the language. More than open for other suggestions ?
kauffj (Migrated from github.com) reviewed 2017-06-01 15:53:13 +02:00
ui/js/selectors/app.js
@ -38,35 +38,28 @@ export const selectPageTitle = createSelector(
selectCurrentParams,
kauffj (Migrated from github.com) commented 2017-06-01 15:53:13 +02:00
Copy link

Yes, just leave it the way that it was. I'm fine if a few problem strings aren't translated to start (though it'd be good to build a list of these).

Yes, just leave it the way that it was. I'm fine if a few problem strings aren't translated to start (though it'd be good to build a list of these).
kauffj (Migrated from github.com) reviewed 2017-06-01 15:55:57 +02:00
ui/js/main.js
kauffj (Migrated from github.com) commented 2017-06-01 15:55:57 +02:00
Copy link

I think it'd make sense for i18n to be set in ui/js/app.js then?

I think it'd make sense for i18n to be set in `ui/js/app.js` then?
kauffj commented 2017-06-01 15:56:45 +02:00 (Migrated from github.com)
Copy link

Please make sure to ping me once the few remaining minor changes are made -- I'll put this in master than so we stop generating conflicts with ongoing work.

Please make sure to ping me once the few remaining minor changes are made -- I'll put this in master than so we stop generating conflicts with ongoing work.
intnick (Migrated from github.com) reviewed 2017-06-01 16:10:29 +02:00
ui/js/selectors/app.js
@ -38,35 +38,28 @@ export const selectPageTitle = createSelector(
selectCurrentParams,
intnick (Migrated from github.com) commented 2017-06-01 16:10:29 +02:00
Copy link

On it. I think a few more have the same case and name so I'll aggregate those as well.

On it. I think a few more have the same case and name so I'll aggregate those as well.
intnick (Migrated from github.com) reviewed 2017-06-01 16:11:08 +02:00
ui/js/main.js
intnick (Migrated from github.com) commented 2017-06-01 16:11:08 +02:00
Copy link

Trying it out

Trying it out
MaxiBoether (Migrated from github.com) reviewed 2017-06-01 17:07:35 +02:00
ui/js/selectors/app.js
@ -38,35 +38,28 @@ export const selectPageTitle = createSelector(
selectCurrentParams,
MaxiBoether (Migrated from github.com) commented 2017-06-01 17:07:35 +02:00
Copy link

I don't know if it helps, but wrapping __() around the output, even if it's not a build-in String (e.g. rewards which are loaded from the server) also work with y18n, you just need to run the app once and then it's added to the language file automatically

I don't know if it helps, but wrapping __() around the output, even if it's not a build-in String (e.g. rewards which are loaded from the server) also work with y18n, you just need to run the app once and then it's added to the language file automatically
kauffj commented 2017-06-02 21:52:51 +02:00 (Migrated from github.com)
Copy link

Please make the changes discussed in Slack.

Please make the changes discussed in Slack.
MaxiBoether commented 2017-06-03 13:35:33 +02:00 (Migrated from github.com)
Copy link

Changes should be made, but please review carefully

Changes should be made, but please review carefully
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#160
No description provided.
Delete branch "i18n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?