More css fixes #1608

2018-06-15T19:07:00+02:00

neb-b commented

2018-06-15 19:07:00 +02:00

(Migrated from github.com)

Very minor CSS changes, mostly dealing with thumbnail placeholders in different parts of the app.

Also added react-toggle to style the autoplay switch. In the future, we will move all checkboxes over to this but there were some alignment issues so I didn't want to bother with it right now.
https://github.com/lbryio/lbry-app/issues/1539
screen shot 2018-06-15 at 4 11 12 pm

Very minor CSS changes, mostly dealing with thumbnail placeholders in different parts of the app. Also added `react-toggle` to style the autoplay switch. In the future, we will move all checkboxes over to this but there were some alignment issues so I didn't want to bother with it right now. https://github.com/lbryio/lbry-app/issues/1539 <img width="400" alt="screen shot 2018-06-15 at 4 11 12 pm" src="https://user-images.githubusercontent.com/16882830/41487460-c2e43d1e-70b6-11e8-8c0c-72f81618a4b1.png">

kauffj (Migrated from github.com) reviewed 2018-06-15 22:42:00 +02:00

kauffj (Migrated from github.com) left a comment

None of these I would consider blockers.

src/renderer/component/common/form-components/form-field.jsx

kauffj (Migrated from github.com) commented

2018-06-15 22:39:05 +02:00

There are only 11 checkboxes in the entire app. Is it worth making this all of them?

Also, does Toggle maintain the keyboard usability of native inputs? If we're replacing native form inputs with custom ones, I'd prefer they function the same as native inputs for accessibility and keyboard use.

In this case, that'd probably mean that you can still tab to them and that space toggles the value.

There are only 11 checkboxes in the entire app. Is it worth making this all of them? Also, does Toggle maintain the keyboard usability of native inputs? If we're replacing native form inputs with custom ones, I'd prefer they function the same as native inputs for accessibility and keyboard use. In this case, that'd probably mean that you can still tab to them and that space toggles the value.

src/renderer/component/common/tooltip.jsx

kauffj (Migrated from github.com) commented

2018-06-15 22:40:38 +02:00

Is there a name for this property that would describe the type of tooltip this is rather than the styling of it?

Is there a name for this property that would describe the _type_ of tooltip this is rather than the styling of it?

src/renderer/component/common/tooltip.jsx

kauffj (Migrated from github.com) commented

2018-06-15 22:40:56 +02:00

Same for this class as the above comment.

src/renderer/scss/component/_tooltip.scss

					
				@ -4,8 +4,8 @@

				}

kauffj (Migrated from github.com) commented

2018-06-15 22:41:43 +02:00

These .tooltip rules can be nested since it's SCSS

These `.tooltip` rules can be nested since it's SCSS

neb-b (Migrated from github.com) reviewed 2018-06-15 22:44:17 +02:00

src/renderer/component/common/form-components/form-field.jsx

neb-b (Migrated from github.com) commented

2018-06-15 22:44:17 +02:00

It was just one checkbox on the settings page that was messed up due to the postfix overlflowing onto a second line. Didn't spend much time on it but yes, all of the checkboxes will use this style (which supports nice usability)

Sign in to join this conversation.

No reviewers