UX changes #1650

2018-06-20T03:15:35+02:00

neb-b commented

2018-06-20 03:15:35 +02:00

(Migrated from github.com)

Changes

Simplified search autocomplete. Tried to make it easier to notifiy users if they are going to a claim/channel/search page
#1598
#1636
Removed auto search, we may add it back but it did not need to be on the FileList component, that was when we had the search modal.
Other minor fixes accross the app

Images

### Changes - Simplified search autocomplete. Tried to make it easier to notifiy users if they are going to a claim/channel/search page - #1598 - #1636 - Removed auto search, we may add it back but it did not need to be on the `FileList` component, that was when we had the search modal. - Other minor fixes accross the app ### Images <img width="400" alt="screen shot 2018-06-19 at 11 38 14 pm" src="https://user-images.githubusercontent.com/16882830/41679455-4744d1ca-749c-11e8-854b-938f79622e50.png"> <img width="400" alt="screen shot 2018-06-20 at 3 17 34 pm" src="https://user-images.githubusercontent.com/16882830/41679722-24060a52-749d-11e8-932e-72edc49e6f34.png"> <img width="400" alt="screen shot 2018-06-20 at 3 17 45 pm" src="https://user-images.githubusercontent.com/16882830/41679732-286db464-749d-11e8-91af-4c78dd9fff12.png">

neb-b commented

2018-06-20 08:56:35 +02:00

(Migrated from github.com)

@tzarebczan a quick test on this would be great

kauffj (Migrated from github.com) reviewed 2018-06-20 23:53:40 +02:00

kauffj (Migrated from github.com) left a comment

This is my feedback on the code itself, feedback on UI coming separately.

src/renderer/component/common/icon.jsx

kauffj (Migrated from github.com) commented

2018-06-20 23:43:27 +02:00

first check no longer adds anything, this can just check for tooltipText

first check no longer adds anything, this can just check for `tooltipText`

src/renderer/component/fileActions/view.jsx

kauffj (Migrated from github.com) commented

2018-06-20 23:45:00 +02:00

Not a blocker, but it'd probably be superior if tooltip could be a property of a button, rather than a component that wraps a button.

src/renderer/scss/component/_tooltip.scss

					
				@ -71,3 +86,4 @@

				    }

				  }

				}

kauffj (Migrated from github.com) commented

2018-06-20 23:50:49 +02:00

The margins on <main> appear to make this safe for realistic use cases, but what would happen if a tooltip is on a button with a width that would extend past the canvas size?

The margins on `<main>` appear to make this safe for realistic use cases, but what would happen if a tooltip is on a button with a width that would extend past the canvas size?

kauffj commented

2018-06-20 23:55:01 +02:00

(Migrated from github.com)

@seanyesmunt there's also a growing number of instances where components are being passed flags that effectively require them to know about what's outside of them rather than operate independently. E.g. onModal, onComponent. We ought to avoid this pattern whenever possible.

@seanyesmunt there's also a growing number of instances where components are being passed flags that effectively require them to know about what's outside of them rather than operate independently. E.g. `onModal`, `onComponent`. We ought to avoid this pattern whenever possible.

👍 1

kauffj commented

2018-06-21 00:01:36 +02:00

(Migrated from github.com)

And here's my UX/UI feedback:

Autoplay has got to change it's place in the layout. It probably shouldn't be it's own row.
Spacing is weird. Here are the relative spaces I measured:
- 36px between "published on..." and the channel indicator
- 32px between the card action /button row and the channel indicator
- 24px between autoplay and action row
- 24px between "About" and autoplay
Some of the above may stem from the usage of form-row in an inappropriate manner.
Would still like to consider other icons than a paper plane for send
I dislike that the first action in the row is "Unsubscribe" once I've subscribed, but I suppose that might be unavoidable.
Why is download faded?
View on web did not work for this URL (lbry://joe-haldeman-from-the-vietnam-war-to#33ad70ec22e757c828d934f571880b42f6cedb77), the first and only one I tried it on. Not sure where to file this. I did not debug this enough to figure it out.

And here's my UX/UI feedback: - Autoplay has got to change it's place in the layout. It probably shouldn't be it's own row. - Spacing is weird. Here are the relative spaces I measured: - 36px between "published on..." and the channel indicator - 32px between the card action /button row and the channel indicator - 24px between autoplay and action row - 24px between "About" and autoplay - Some of the above may stem from the usage of `form-row` in an inappropriate manner. - Would still like to consider other icons than a paper plane for send - I dislike that the first action in the row is "Unsubscribe" once I've subscribed, but I suppose that might be unavoidable. - Why is download faded? - View on web did not work for this URL (lbry://joe-haldeman-from-the-vietnam-war-to#33ad70ec22e757c828d934f571880b42f6cedb77), the first and only one I tried it on. Not sure where to file this. I did not debug this enough to figure it out.

👍 1

neb-b (Migrated from github.com) reviewed 2018-06-21 00:06:09 +02:00

src/renderer/component/fileActions/view.jsx

neb-b (Migrated from github.com) commented

2018-06-21 00:06:09 +02:00

Ooh that's a good idea.

neb-b (Migrated from github.com) reviewed 2018-06-21 00:08:14 +02:00

src/renderer/scss/component/_tooltip.scss

					
				@ -71,3 +86,4 @@

				    }

				  }

				}

neb-b (Migrated from github.com) commented

2018-06-21 00:08:14 +02:00

Tooltips can extend past the margin with no issues

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1650