Can't right click > paste into description on publish #1664

New issue

Closed

opened 2018-06-21 07:39:19 +02:00 by tzarebczan · 3 comments

tzarebczan commented

2018-06-21 07:39:19 +02:00

(Migrated from github.com)

The Issue

Can use ctrl-v, but right click doesn't work in Publish > Description. Might be worth looking into other parts of the app also.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue Can use ctrl-v, but right click doesn't work in Publish > Description. Might be worth looking into other parts of the app also. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

QuirkyRobots commented

2018-06-21 11:32:08 +02:00

(Migrated from github.com)

The description area needs to be an Input HTMLElement. When I change the span to an input it works. However, it then requires restyling.

<span class="cm-null cm-spell-error">This is the description text area, which is not an Input HTMLElement</span>

The code only lets the context menu work on inputs.

  // If context menu is opened on Input and text is present on clipboard
  if (clipboard.readText().length > 0 && isInput) {
    templates.push({
      label: 'Paste',
      accelerator: 'CmdOrCtrl+V',
      role: 'paste',
    });
  }

See contextMenu.js

Also affects the "Report a Bug or Suggest a New Feature" area.

The **description** area needs to be an **Input HTMLElement**. When I change the **span** to an **input** it works. However, it then requires **restyling**. ```html <span class="cm-null cm-spell-error">This is the description text area, which is not an Input HTMLElement</span> ``` The code only lets the **context menu** work on **inputs**. ```js // If context menu is opened on Input and text is present on clipboard if (clipboard.readText().length > 0 && isInput) { templates.push({ label: 'Paste', accelerator: 'CmdOrCtrl+V', role: 'paste', }); } ``` See [contextMenu.js](https://github.com/lbryio/lbry-app/blob/ae93a0d95d9209ea40d897bba0fdfa7c1f08028a/src/renderer/util/contextMenu.js) Also affects the "**__Report a Bug or Suggest a New Feature__**" area. ![image](https://user-images.githubusercontent.com/29914179/41712135-23a752e6-758d-11e8-9d45-e815f5928718.png)

btzr-io commented

2018-06-21 19:13:32 +02:00

(Migrated from github.com)

This requires a more complex fix 🙃 ^^
See https://github.com/RIP21/react-simplemde-editor/issues/67

This requires a more complex fix :upside_down_face: ^^ See https://github.com/RIP21/react-simplemde-editor/issues/67

btzr-io commented

2018-06-21 19:25:52 +02:00

(Migrated from github.com)

Also I don't think that's the correct style for textarea of dark-theme
@tzarebczan Should we open a new issue for that? ^

Also I don't think that's the correct style for `textarea` of dark-theme @tzarebczan Should we open a new issue for that? ^