use spee.ch publish config endpoint for thumbnail status #1685

Merged
neb-b merged 1 commit from speech-status into master 2018-06-25 19:40:03 +02:00
neb-b commented 2018-06-25 18:06:05 +02:00 (Migrated from github.com)
No description provided.
bones7242 (Migrated from github.com) reviewed 2018-06-25 18:59:48 +02:00
bones7242 (Migrated from github.com) commented 2018-06-25 18:59:48 +02:00

I think this should be
if (status.disabled) {
because you want to throw the error in the case where disabled is true. i.e. if it is disabled, then api is down

I think this should be `if (status.disabled) {` because you want to throw the error in the case where disabled is `true`. i.e. if it _is_ disabled, _then_ api is down
bones7242 (Migrated from github.com) requested changes 2018-06-25 19:01:45 +02:00
bones7242 (Migrated from github.com) left a comment

I believe the status.disabled check needs to be reversed

I believe the `status.disabled` check needs to be reversed
neb-b (Migrated from github.com) reviewed 2018-06-25 19:38:57 +02:00
neb-b (Migrated from github.com) commented 2018-06-25 19:38:57 +02:00

whoops. Used that when I was testing

whoops. Used that when I was testing
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1685
No description provided.