LBRYCommunity/lbry-desktop

Tourniquets Text Over 20VW to Fix Table Length Issue #1692

Merged

QuirkyRobots merged 3 commits from patch-1 into master

2018-06-27 07:53:48 +02:00

QuirkyRobots commented

2018-06-26 08:19:25 +02:00

(Migrated from github.com)

Fixes table length issue https://github.com/lbryio/lbry-app/issues/1690

BEFORE

AFTER

Fixes table length issue https://github.com/lbryio/lbry-app/issues/1690 ### BEFORE ![image](https://user-images.githubusercontent.com/29914179/41892694-73a1f04e-795c-11e8-91ae-da481383ca38.png) ### AFTER ![image](https://user-images.githubusercontent.com/29914179/41892814-dbeeb8c6-795c-11e8-832b-71e25e330251.png)

QuirkyRobots commented

2018-06-26 08:49:39 +02:00

(Migrated from github.com)

Using Viewport Width (vw) makes it responsive, thus it works at all sizes without out the need for conditional media queries.

Using **Viewport Width** (vw) makes it **responsive**, thus it works at all sizes without out the need for **conditional media queries**.

neb-b commented

2018-06-27 07:50:36 +02:00

(Migrated from github.com)

This is great.

This is great.

QuirkyRobots commented

2018-06-27 08:00:21 +02:00

(Migrated from github.com)

Thanks @seanyesmunt I was looking for it to auto tourniquet based on the current %width, but it would only work with a set VW (viewport width).

I will spend more time on this at a later date and play around with things like converting the current table % values to VW to see if that is a better solution that will be globally acceptable for any sized area, which I think was @kauffj's concern.

For now, these are a good fix with the current layout.

Thanks @seanyesmunt I was looking for it to **auto tourniquet** based on the current `%width`, but it would only work with a set `VW` (viewport width). I will spend more time on this at a later date and play around with things like converting the current table % values to VW to see if that is a better solution that will be globally acceptable for any sized area, which I think was @kauffj's concern. For now, these are a good fix with the current layout.

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1692

No description provided.