LBRYCommunity/lbry-desktop

Tourniquets Text to Fix Table Length Issue in Help #1694

Merged

QuirkyRobots merged 2 commits from patch-3 into master

2018-06-27 07:48:25 +02:00

QuirkyRobots commented

2018-06-26 15:44:28 +02:00

(Migrated from github.com)

Same CSS issue and fix as https://github.com/lbryio/lbry-app/pull/1692 which fixes tables issues when the app is at minimum width.

These little details help keep the app looking professional, thus helping brand reputation/authority.

BEFORE

AFTER

Same **CSS** issue and fix as https://github.com/lbryio/lbry-app/pull/1692 which fixes tables issues when the app is at minimum width. These little details help keep the app looking professional, thus helping brand reputation/authority. ### BEFORE ![image](https://user-images.githubusercontent.com/29914179/41916005-69f392b2-799a-11e8-86ce-8f9ba91818ee.png) ### AFTER ![image](https://user-images.githubusercontent.com/29914179/41916032-743584d8-799a-11e8-8420-ea55093c2e74.png)

kauffj (Migrated from github.com) reviewed 2018-06-26 16:18:24 +02:00

src/renderer/scss/component/_table.scss

kauffj (Migrated from github.com) commented

2018-06-26 16:18:23 +02:00

This probably can't become a property of all final table cells.

This probably can't become a property of all final table cells.

QuirkyRobots commented

2018-06-26 17:23:13 +02:00

(Migrated from github.com)

Was better placed in the HELP section of the CSS. This way, it's only affecting the HELP table and not global assets.

table.table--help {
  td:nth-of-type(1) {
    color: var(--text-color);
    font-family: 'metropolis-semibold';
    min-width: 130px;
  }
    td:nth-of-type(2) {
/*Tourniquets text over 20VW*/
    max-width: 20vw;
    overflow: hidden;
    white-space: nowrap;
    text-overflow: ellipsis;
  }
}

Was better placed in the HELP section of the CSS. This way, it's only affecting the HELP table and not global assets. ```css table.table--help { td:nth-of-type(1) { color: var(--text-color); font-family: 'metropolis-semibold'; min-width: 130px; } td:nth-of-type(2) { /*Tourniquets text over 20VW*/ max-width: 20vw; overflow: hidden; white-space: nowrap; text-overflow: ellipsis; } } ```

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1694

No description provided.