Search by default if URL entered does not resolve #1699

New issue

Closed

opened 2018-06-26 21:44:37 +02:00 by tzarebczan · 5 comments

tzarebczan commented

2018-06-26 21:44:37 +02:00

(Migrated from github.com)

The Issue

Currently, if you enter a single word (or something with a -) search term, the default behavior is to go to the URL even if it may not exist. We should resolve it, or have the resolution status return from Lighthouse, and search by default if it doesn't resolve properly.

@seanyesmunt / @tiger5226 do you think this is possible on app side only, or needs Lighthouse support?

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue Currently, if you enter a single word (or something with a -) search term, the default behavior is to go to the URL even if it may not exist. We should resolve it, or have the resolution status return from Lighthouse, and search by default if it doesn't resolve properly. @seanyesmunt / @tiger5226 do you think this is possible on app side only, or needs Lighthouse support? ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

neb-b commented

2018-06-27 17:04:58 +02:00

(Migrated from github.com)

This can happen entirely in the app

On Tue, Jun 26, 2018 at 3:44 PM, Thomas Zarebczan notifications@github.com
wrote:

The Issue

Currently, if you enter a single word (or something with a -) search term,
the default behavior is to go to the URL even if it may not exist. We
should resolve it, or have the resolution status return from Lighthouse,
and search by default if it doesn't resolve properly.

@seanyesmunt https://github.com/seanyesmunt / @tiger5226
https://github.com/tiger5226 do you think this is possible on app side
only, or needs Lighthouse support?
System Configuration

LBRY Daemon version:

LBRY App version:

LBRY Installation ID:

Operating system:

Anything Else Screenshots

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/1699, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjgOn14m7pxOU4FL9tQEczT25mZpUks5uAo8ogaJpZM4U4kCv
.

--
Sean Yesmunt
Application Engineer for LBRY

This can happen entirely in the app On Tue, Jun 26, 2018 at 3:44 PM, Thomas Zarebczan <notifications@github.com> wrote: > The Issue > > Currently, if you enter a single word (or something with a -) search term, > the default behavior is to go to the URL even if it may not exist. We > should resolve it, or have the resolution status return from Lighthouse, > and search by default if it doesn't resolve properly. > > @seanyesmunt <https://github.com/seanyesmunt> / @tiger5226 > <https://github.com/tiger5226> do you think this is possible on app side > only, or needs Lighthouse support? > System Configuration > > - LBRY Daemon version: > - LBRY App version: > - LBRY Installation ID: > - Operating system: > > Anything Else Screenshots > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/1699>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjgOn14m7pxOU4FL9tQEczT25mZpUks5uAo8ogaJpZM4U4kCv> > . > -- Sean Yesmunt Application Engineer for LBRY

tiger5226 commented

2018-06-28 03:09:15 +02:00

(Migrated from github.com)

This is a duplicate of another issue. We can definitely resolve it first and if it resolves go to url and if not perform search.

This is a duplicate of another [issue](https://github.com/lbryio/lbry-app/issues/1496). We can definitely resolve it first and if it resolves go to url and if not perform search.

tiger5226 commented

2018-07-07 15:24:07 +02:00

(Migrated from github.com)

closed the other issue in favor of this one. To summarize, solving the issue of going to an empty URI against the intention of the user, we should be smarter about it. With recent improvements in the daemon, we can now resolve, then if nothing is at that uri, fallback and do a search.

alyssaoc commented

2018-09-27 21:20:27 +02:00

(Migrated from github.com)

@seanyesmunt Is this complete?

tzarebczan commented

2018-09-27 22:10:27 +02:00

(Migrated from github.com)

Yes, the new search works in a way that shows the current item typed as well as search results. Closing...