Can't Edit Existing Claim if Deposit Value is Changed #1712

New issue

Closed

opened 2018-06-28 16:24:20 +02:00 by QuirkyRobots · 4 comments

QuirkyRobots commented

2018-06-28 16:24:20 +02:00

(Migrated from github.com)

If you click in to the deposit area and change the value, you can no longer edit unless you have that entire value in your wallet, which isn't necessary because you've already made your claim.

Solution to this can also be the solution to @tzarebczan's filed issue: https://github.com/lbryio/lbry-app/issues/634

Before Value Changed Then Changed Back

After Value Changed Then Changed Back

If you click in to the **deposit area** and **change** the **value**, you can no longer **edit** unless you have that **entire value** in your wallet, which isn't necessary because you've already made your claim. Solution to this can also be the solution to @tzarebczan's filed issue: https://github.com/lbryio/lbry-app/issues/634 ### Before Value Changed Then Changed Back ![image](https://user-images.githubusercontent.com/29914179/42040081-309f8022-7b32-11e8-9c98-2f8e174cee40.png) ### After Value Changed Then Changed Back ![image](https://user-images.githubusercontent.com/29914179/42040088-35867ce4-7b32-11e8-89e5-6c4ad10d4438.png)

tzarebczan commented

2018-06-28 17:15:16 +02:00

(Migrated from github.com)

Ah, good point... Completly forgot about this when I made the ux enhancements.

@seanyesmunt do you think we can get the current claim deposit and add that to the balance for this simple check? I'll look into this.

Ah, good point... Completly forgot about this when I made the ux enhancements. @seanyesmunt do you think we can get the current claim deposit and add that to the balance for this simple check? I'll look into this.

👍 1

QuirkyRobots commented

2018-06-28 17:52:26 +02:00

(Migrated from github.com)

Just noticed - Styling issue with "I agree to the" text in above screengrab,

Just noticed - Styling issue with "`I agree to the`" text in above screengrab,

tzarebczan commented

2018-06-28 17:55:56 +02:00

(Migrated from github.com)

I'm not seeing the same in the prod version. But I think I saw something similar on another screen via Dev mode/master. Let me see if it's something to do with Dev mode, or a recent change.

Edit: opened: https://github.com/lbryio/lbry-app/issues/1713

I'm not seeing the same in the prod version. But I think I saw something similar on another screen via Dev mode/master. Let me see if it's something to do with Dev mode, or a recent change. Edit: opened: https://github.com/lbryio/lbry-app/issues/1713

👍 1

neb-b commented

2018-07-02 20:45:26 +02:00

(Migrated from github.com)

Fixed in https://github.com/lbryio/lbry-app/pull/1725