Chanding Video URL During Edit Changes The Edit Button To Publish Giving An Error Message #1714

New issue

Closed

opened 2018-06-28 18:37:18 +02:00 by ceoger · 5 comments

ceoger commented

2018-06-28 18:37:18 +02:00

(Migrated from github.com)

The Issue

I tried editing a video i published and what happens is, when i change the video url under "Where can people find this content" the edit button changes to publish giving error massage of "no source provided to publish" if this is suppose to be the case then how about (graying out the url under "where can people find my video" when we want to edit)

Steps to Reproduce

Go to publishes
Select any video previously published
Select edit
try changing the video url to another url
Right away, edit changes to publish
Click publish and you get the error message "no source provided to publish"

Expected Behaviour

Tell us what should happen.
We should be able to change URL without having to publish the file again, otherwise the option for changing url should be grayed out so we wont be able to modify that

Actual Behaviour

the option to change url remains and when i change url, the edit changes to publish

System Configuration

LBRY Daemon version: 0.20.2
LBRY App version: 0.22.0
LBRY Installation ID: 3cXLZiAWXwwJbv4fjhbXVgFtaBuUiFQM7afXmFYu5ss1chD1WCpxGUp8aW68gjeNRC
Operating system: Windows (Windows-10-10.0.16299)

Anything Else

Screenshots

example of graying out a url input
https://cdn.discordapp.com/attachments/377895389992321064/461808954297679882/unknown.png

https://cdn.discordapp.com/attachments/377895389992321064/461809010614730752/disable.JPG

## The Issue I tried editing a video i published and what happens is, when i change the video url under "Where can people find this content" the edit button changes to publish giving error massage of "no source provided to publish" if this is suppose to be the case then how about (graying out the url under "where can people find my video" when we want to edit) ### Steps to Reproduce 1. Go to publishes 2. Select any video previously published 3. Select edit 4. try changing the video url to another url 5. Right away, edit changes to publish 6. Click publish and you get the error message "no source provided to publish" ### Expected Behaviour Tell us what should happen. We should be able to change URL without having to publish the file again, otherwise the option for changing url should be grayed out so we wont be able to modify that ### Actual Behaviour the option to change url remains and when i change url, the edit changes to publish ### Suggested Solutions if this is suppose to be the case then how about (graying out the url under "where can people find my video" when we want to edit) otherwise the edit button should not change to publish after modifying video url ## System Configuration   - LBRY Daemon version: 0.20.2 - LBRY App version: 0.22.0 - LBRY Installation ID: 3cXLZiAWXwwJbv4fjhbXVgFtaBuUiFQM7afXmFYu5ss1chD1WCpxGUp8aW68gjeNRC - Operating system: Windows (Windows-10-10.0.16299) ## Anything Else  ## Screenshots  example of graying out a url input https://cdn.discordapp.com/attachments/377895389992321064/461808954297679882/unknown.png https://cdn.discordapp.com/attachments/377895389992321064/461809010614730752/disable.JPG

tzarebczan commented

2018-06-28 19:00:14 +02:00

(Migrated from github.com)

Nice find and thanks for filing! We should either grey out the claim name during edit, or if they change it, alert them to select a file.

ceoger commented

2018-06-28 19:14:21 +02:00

(Migrated from github.com)

@tzarebczan alerting them to select a file, isn't it going to be a publish? maybe they do not want to publish the same file again just updating the url, so i think either an option to change url or no option to change at all. they they can publish the same file again and use the preferred url

neb-b commented

2018-06-28 20:09:29 +02:00

(Migrated from github.com)

This one is tricky. We use the old url to retrieve the previously published file. If you change the url I'm not sure how we would determine if this is an edit or a new publish.

I like the idea of just disabling the input on edit. Maybe next to it we can say This is an edit so you can't change the url, to start a new publish click "here" or something similar.

This one is tricky. We use the old url to retrieve the previously published file. If you change the url I'm not sure how we would determine if this is an edit or a new publish. I like the idea of just disabling the input on edit. Maybe next to it we can say `This is an edit so you can't change the url, to start a new publish click "here"` or something similar.

👍 3

ceoger commented

2018-06-28 20:17:08 +02:00

(Migrated from github.com)

@seanyesmunt
I like the idea of just disabling the input on edit. Maybe next to it we can say

This is an edit so you can't change the url, to start a new publish click "here"
or something similar.

sounds like perfect 💯

@seanyesmunt **I like the idea of just disabling the input on edit**. Maybe next to it we can say > This is an edit so you can't change the url, to start a new publish click "here" or something similar. sounds like perfect :100:

👍 1

neb-b commented

2018-07-02 20:26:30 +02:00

(Migrated from github.com)

Instead of disabling we are just going to add a more descriptive label and disable the form if you started an edit, then changed the name (which should have been happening before).