Publish fixes #1716

2018-06-28T22:14:20+02:00

neb-b commented

2018-06-28 22:14:20 +02:00

(Migrated from github.com)

Fixes

Disabled the file input when publishing === true
Fix an issue with form error styling at the bottom of the publish form
https://github.com/lbryio/lbry-app/issues/1714
https://github.com/lbryio/lbry-app/issues/1647

Moved button styling to be specific to the transactions table because it was affecting buttons it shouldn't.

#### Fixes Disabled the file input when `publishing === true` Fix an issue with form error styling at the bottom of the publish form https://github.com/lbryio/lbry-app/issues/1714 https://github.com/lbryio/lbry-app/issues/1647 Moved button styling to be specific to the transactions table because it was affecting buttons it shouldn't.

tzarebczan commented

2018-07-02 19:37:00 +02:00

(Migrated from github.com)

Tested and working as expected for me. When I edit the name, I get the warning about selecting a file. Publish works after going down that route. Also able to change the name back and edit as expected.

kauffj (Migrated from github.com) requested changes 2018-07-02 23:51:58 +02:00

kauffj (Migrated from github.com) left a comment

I would like the application of the tourniquitting CSS to be improved and then you can merge this without another review.

src/renderer/component/publishForm/view.jsx

					
				@ -273,2 +293,4 @@

				        </div>

				      )

				    );

				  }

kauffj (Migrated from github.com) commented

2018-07-02 23:48:06 +02:00

This is fine, but it's worth considering in the future how at least some of these could be funneled directly to the fields rather than all shown in a global area.

src/renderer/scss/component/_table.scss

kauffj (Migrated from github.com) commented

2018-07-02 23:50:23 +02:00

I like this tourniquitting CSS but I dislike how it is being applied. Is tourniqueting text really just a property of button links when they're inside the 3rd td element of a <table.table--help>? This seems unlikely.

If we're struggling to find a clear global rule for these, I think it makes more sense to apply turniquitting as either a table or cell level class property.

I like this tourniquitting CSS but I dislike how it is being applied. Is tourniqueting text really just a property of button links when they're inside the 3rd `td` element of a `<table.table--help>`? This seems unlikely. If we're struggling to find a clear global rule for these, I think it makes more sense to apply turniquitting as either a table or cell level class property.

kauffj (Migrated from github.com) reviewed 2018-07-02 23:52:30 +02:00

src/renderer/scss/component/_table.scss

kauffj (Migrated from github.com) commented

2018-07-02 23:52:30 +02:00

Also, this breaks BEM

neb-b (Migrated from github.com) reviewed 2018-07-03 00:09:08 +02:00

src/renderer/component/publishForm/view.jsx

					
				@ -273,2 +293,4 @@

				        </div>

				      )

				    );

				  }

neb-b (Migrated from github.com) commented

2018-07-03 00:09:08 +02:00

They are shown in the field, this is just extra help at the bottom of the page so it isn't confusing why the publish button is greyed out.

They are shown in the field, this is just extra help at the bottom of the page so it isn't confusing why the `publish` button is greyed out.

kauffj (Migrated from github.com) reviewed 2018-07-03 00:15:56 +02:00

src/renderer/component/publishForm/view.jsx

					
				@ -273,2 +293,4 @@

				        </div>

				      )

				    );

				  }

kauffj (Migrated from github.com) commented

2018-07-03 00:15:56 +02:00

👍

:+1:

kauffj (Migrated from github.com) reviewed 2018-07-03 00:16:44 +02:00

src/renderer/component/publishForm/view.jsx

					
				@ -273,2 +293,4 @@

				        </div>

				      )

				    );

				  }

kauffj (Migrated from github.com) commented

2018-07-03 00:16:43 +02:00

(On second thought, this still feels somewhat wrong. Maybe the superior pattern is one that provides a link to scroll to the fields with errors? But obviously non-blocking)

neb-b (Migrated from github.com) reviewed 2018-07-03 00:24:59 +02:00

src/renderer/component/publishForm/view.jsx

					
				@ -273,2 +293,4 @@

				        </div>

				      )

				    );

				  }

neb-b (Migrated from github.com) commented

2018-07-03 00:24:59 +02:00

I like that idea 👍

Sign in to join this conversation.

No reviewers

kauffj

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1716

Rows
Columns