"Upgrade on Close" doesn't close because multiple modals open #1747

New issue

Closed

opened 2018-07-10 01:52:54 +02:00 by tzarebczan · 7 comments

tzarebczan commented

2018-07-10 01:52:54 +02:00

(Migrated from github.com)

The Issue

If a user has the LBRY app open and an update is out, it will create a modal every 10 minutes. So if you try to click the "Upgrade on Close" button - it won't actually close because you need to click it multiple times.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue If a user has the LBRY app open and an update is out, it will create a modal every 10 minutes. So if you try to click the "Upgrade on Close" button - it won't actually close because you need to click it multiple times. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

doniyor2109 commented

2018-07-30 19:39:56 +02:00

(Migrated from github.com)

I have tested "Upgrade on Close" button but it works as expected

doniyor2109 commented

2018-07-30 19:40:40 +02:00

(Migrated from github.com)

What is the platform name that the case occurred?

tzarebczan commented

2018-07-30 21:27:20 +02:00

(Migrated from github.com)

@doniyor2109 - did you leave the app open more than 10/20 minutes? The upgrade on close stack up on one another when the updater checks for new updates. This would only happen on Mac/Windows.

doniyor2109 commented

2018-08-01 09:01:47 +02:00

(Migrated from github.com)

I waited sometime nothing happened. I will wait sometime again

tzarebczan commented

2018-08-01 09:46:27 +02:00

(Migrated from github.com)

Nothing is meaning you weren't notified of an update or you didn't run into the modals stacking?

To reproduce, you must download an earlier version like https://github.com/lbryio/lbry-desktop/releases/tag/v0.22.2

Nothing is meaning you weren't notified of an update or you didn't run into the modals stacking? To reproduce, you must download an earlier version like https://github.com/lbryio/lbry-desktop/releases/tag/v0.22.2

tzarebczan commented

2018-08-02 01:06:09 +02:00

(Migrated from github.com)

@doniyor2109 you should be able to reproduce if you are on 0.23.0 (0.23.1 launched today) on Windows/Mac.

doniyor2109 commented

2018-08-06 19:32:20 +02:00

(Migrated from github.com)

@tzarebczan Sorry for late response. Can you check the PR for the issue? I have linux so I could not test it.