hide community row if nsfw content is hidden #1760

2018-07-12T03:55:17+02:00

neb-b commented

2018-07-12 03:55:17 +02:00

(Migrated from github.com)

I think we should keep the "row" styling somewhat there. Then users know this would be a scrollable row just like the other rows, if they change their settings.

I think we should keep the "row" styling somewhat there. Then users know this would be a scrollable row just like the other rows, if they change their settings. <img width="400" alt="screen shot 2018-07-11 at 9 54 28 pm" src="https://user-images.githubusercontent.com/16882830/42608290-1503c760-8555-11e8-96a1-54fd86145a0d.png">

neb-b (Migrated from github.com) reviewed 2018-07-12 03:57:00 +02:00

src/renderer/scss/component/_card.scss

					
				@ -22,4 +22,3 @@

				.card--small {

				  width: var(--card-small-width);

				  white-space: normal;

neb-b (Migrated from github.com) commented

2018-07-12 03:57:00 +02:00

this wasn't doing anything.

neb-b (Migrated from github.com) reviewed 2018-07-12 03:57:58 +02:00

src/renderer/scss/component/_card.scss

					
				@ -283,6 +281,14 @@

				  &:last-of-type {

neb-b (Migrated from github.com) commented

2018-07-12 03:57:58 +02:00

This is needed because of the special CSS that happens inside the CategoryList component, that allows content to scroll "off" the side of the edge. That behavior doesn't exist anywhere else in the app.

skhameneh (Migrated from github.com) approved these changes 2018-07-12 04:05:19 +02:00

src/renderer/component/categoryList/view.jsx

					
				@ -1,11 +1,11 @@

				// @flow

				import React from 'react';

				import * as React from 'react';

				import { normalizeURI } from 'lbry-redux';

skhameneh (Migrated from github.com) commented

2018-07-12 04:04:38 +02:00

why this change?

neb-b (Migrated from github.com) reviewed 2018-07-12 04:37:26 +02:00

src/renderer/component/categoryList/view.jsx

					
				@ -1,11 +1,11 @@

				// @flow

				import React from 'react';

				import * as React from 'react';

				import { normalizeURI } from 'lbry-redux';

neb-b (Migrated from github.com) commented

2018-07-12 04:37:25 +02:00

It's needed after adding React.Fragment. Flow acts funny without it.

It's needed after adding `React.Fragment`. Flow acts funny without it.

tzarebczan commented

2018-07-12 19:18:08 +02:00

(Migrated from github.com)

This looks good to me and confirmed with Rob that will move trending to top (or 2nd from top) so that Community top bids will be at the bottom. This means we won't have to worry about the weird spacing.

Sign in to join this conversation.

No reviewers

skhameneh