Add warning when opening files externally #1761

New issue

Closed

opened 2018-07-12 06:36:26 +02:00 by tzarebczan · 2 comments

tzarebczan commented

2018-07-12 06:36:26 +02:00

(Migrated from github.com)

The Issue

When using the open button (and possibly when clicking the file location at the bottom of a downloaded claim), we should warn users that they are opening at their own risk. FIles played inside the app are sandboxed, but anything opened externally could be a risk. Maybe we only do this for non-playable/viewable types?

It would be similar to the modal when clicking a hyperlink in a claim.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue When using the open button (and possibly when clicking the file location at the bottom of a downloaded claim), we should warn users that they are opening at their own risk. FIles played inside the app are sandboxed, but anything opened externally could be a risk. Maybe we only do this for non-playable/viewable types? It would be similar to the modal when clicking a hyperlink in a claim. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

neb-b commented

2018-07-16 15:15:09 +02:00

(Migrated from github.com)

This should use the same styling as the openExternalLink modal. Maybe we can combine them into one modal?

@btzr-io This might be a good one for you if you are interested.

This should use the same styling as the `openExternalLink` modal. Maybe we can combine them into one modal? @btzr-io This might be a good one for you if you are interested.

tzarebczan commented

2019-05-21 16:45:35 +02:00

(Migrated from github.com)

This was completed in https://github.com/lbryio/lbry-desktop/pull/2478