LBRYCommunity/lbry-desktop

suppress load video error #1768

Merged

daovist merged 6 commits from suppress-load-video-error into master

2018-07-19 16:42:24 +02:00

daovist commented

2018-07-13 18:19:27 +02:00

(Migrated from github.com)

Depends on /lbryio/lbry-redux/issues/57

Refactor video loading error into a single function handleLoadVideoError and use for timeout and catch.

Suppress error notification when the user is playing another video. We could also suppress the error when no video is playing?

This fix introduced an issue with autoplay where it keeps trying again after it fails and stacks error messages. I added (in 'lbry-redux) an error property to fileInfo. When a video fails to load the uri is added to the error object with value true. If this value is true for a given uri, that media will not autoplay. This value is deleted when the video starts to load/play again.

#1612 Depends on [/lbryio/lbry-redux/issues/57](https://github.com/lbryio/lbry-redux/pull/57) Refactor video loading error into a single function `handleLoadVideoError` and use for timeout and catch. Suppress error notification when the user is playing another video. We could also suppress the error when no video is playing? This fix introduced an issue with autoplay where it keeps trying again after it fails and stacks error messages. I added (in '`lbry-redux`) an `error` property to `fileInfo`. When a video fails to load the `uri` is added to the `error` object with value true. If this value is true for a given uri, that media will not autoplay. This value is deleted when the video starts to load/play again.

kauffj commented

2018-07-18 19:21:36 +02:00

(Migrated from github.com)

This issue/solution might highlight that what the app really needs is an error/notification queue (e.g. something like the one on GitHub).

(This is separate from the PR, which would still be an approvement over the status quo.)

This issue/solution might highlight that what the app really needs is an error/notification queue (e.g. something like the one on GitHub). (This is separate from the PR, which would still be an approvement over the status quo.)

neb-b (Migrated from github.com) approved these changes 2018-07-19 16:01:53 +02:00

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1768

No description provided.