Invalid char in channel name causes app to throw error #177

New issue

Closed

opened 2017-06-01 16:27:09 +02:00 by lyoshenka · 4 comments

lyoshenka commented

2017-06-01 16:27:09 +02:00

(Migrated from github.com)

Reilly typoed a featured channel, adding an extra comma at the end. This broke the homepage completely. App should do a better job recovering from this.

Channel overwatch-horizon-trailer,

Error:

Uncaught (in promise) Error: Invalid character in name: ,.
    at Object.lbryuri.parse (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:31453:12)
    at Object.lbryuri.normalize (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:31550:33)
    at file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:53301:123
    at Array.map (native)
    at FeaturedCategory (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:53300:21)
    at file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24153:17
    at measureLifeCyclePerf (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:23922:13)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24152:15)
    at ReactCompositeComponentWrapper._constructComponent (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24127:22)
    at ReactCompositeComponentWrapper.mountComponent (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24035:22)

Reilly typoed a featured channel, adding an extra comma at the end. This broke the homepage completely. App should do a better job recovering from this. Channel `overwatch-horizon-trailer,` Error: ``` Uncaught (in promise) Error: Invalid character in name: ,. at Object.lbryuri.parse (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:31453:12) at Object.lbryuri.normalize (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:31550:33) at file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:53301:123 at Array.map (native) at FeaturedCategory (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:53300:21) at file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24153:17 at measureLifeCyclePerf (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:23922:13) at ReactCompositeComponentWrapper._constructComponentWithoutOwner (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24152:15) at ReactCompositeComponentWrapper._constructComponent (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24127:22) at ReactCompositeComponentWrapper.mountComponent (file:///Applications/LBRY.app/Contents/Resources/app/dist/js/bundle.js:24035:22) ```

tzarebczan commented

2017-06-01 20:36:00 +02:00

(Migrated from github.com)

Looks like the same as this issue I reported last night https://github.com/lbryio/lbry-app/issues/174 Will close it.

Edit - Alex said it could be different, I looked at it too quickly. Sorry!

Looks like the same as this issue I reported last night https://github.com/lbryio/lbry-app/issues/174 Will close it. Edit - Alex said it could be different, I looked at it too quickly. Sorry!

btzr-io commented

2017-09-01 05:43:38 +02:00

(Migrated from github.com)

I can't recreate this in 15.0.0
@tzarebczan I think this was also fixed ?

I can't recreate this in `15.0.0` @tzarebczan I think this was also fixed ?

btzr-io commented

2017-09-01 05:47:42 +02:00

(Migrated from github.com)

Yeah, already fixed here:
https://github.com/lbryio/lbry-app/blob/master/ui/js/lbryuri.js#L6
https://github.com/lbryio/lbry-app/blob/master/ui/js/lbryuri.js#L30

Yeah, already fixed here: https://github.com/lbryio/lbry-app/blob/master/ui/js/lbryuri.js#L6 https://github.com/lbryio/lbry-app/blob/master/ui/js/lbryuri.js#L30

tzarebczan commented

2017-09-05 18:36:20 +02:00

(Migrated from github.com)

Thanks @btzr-io , will close.