Can't open app on Mac/Linux if GitHub API call fails #1774

New issue

Closed

opened 2018-07-16 20:39:49 +02:00 by tzarebczan · 1 comment

tzarebczan commented

2018-07-16 20:39:49 +02:00

(Migrated from github.com)

The Issue

GitHub was down for a few minutes and someone reported not being able to access the app. Add additional error checking for the GitHub API call (e1210f7805/src/main/index.js (L184)) so that it doesn't prevent app startup if GitHub is down.

There is an uncaught Json error called on startup for Mac/Linux or on the help page for Windows. (don't have a screenshot). Probably occurring here: e1210f7805/src/main/index.js (L197)

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue GitHub was down for a few minutes and someone reported not being able to access the app. Add additional error checking for the GitHub API call (https://github.com/lbryio/lbry-desktop/blob/e1210f78051e984f26905c01f5d7eac454adad01/src/main/index.js#L184) so that it doesn't prevent app startup if GitHub is down. There is an uncaught Json error called on startup for Mac/Linux or on the help page for Windows. (don't have a screenshot). Probably occurring here: https://github.com/lbryio/lbry-desktop/blob/e1210f78051e984f26905c01f5d7eac454adad01/src/main/index.js#L197 ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots