Disable channel hyperlinks on channel page #1796

Closed
opened 2018-07-20 18:01:23 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2018-07-20 18:01:23 +02:00 (Migrated from github.com)

The Issue

When you are on a channel page, the file card's channel is still clickable which leads you back to the same page and duplicates havigation history. We should disable channel hyperlinks on the channel page.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue When you are on a channel page, the file card's channel is still clickable which leads you back to the same page and duplicates havigation history. We should disable channel hyperlinks on the channel page. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
tzarebczan commented 2018-07-20 19:56:50 +02:00 (Migrated from github.com)

After discussing with @seanyesmunt and the latest fix for channel navigation, we're gonna close this. If you are on page 1 and click the channel, nothing will happen (and navigation works). If you are on page 2 and click it, will take you back to page 1.

After discussing with @seanyesmunt and the latest fix for channel navigation, we're gonna close this. If you are on page 1 and click the channel, nothing will happen (and navigation works). If you are on page 2 and click it, will take you back to page 1.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1796
No description provided.