Differentiate between blank and incorrect URL on Publish thumbnail preview #1808

Closed
opened 2018-07-24 17:05:31 +02:00 by tzarebczan · 2 comments
tzarebczan commented 2018-07-24 17:05:31 +02:00 (Migrated from github.com)

The Issue

Currently, the same "broken" image is shown when there is no URL or an incorrect URL is entered. We should differentiate between the two scenarios to make it clearer for the user.

thumb preview

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue Currently, the same "broken" image is shown when there is no URL or an incorrect URL is entered. We should differentiate between the two scenarios to make it clearer for the user. ![thumb preview](https://user-images.githubusercontent.com/8120721/43147556-4e1f441c-8f31-11e8-9e6f-d97acb41d6cf.jpg) ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
dan1d commented 2018-07-27 22:57:09 +02:00 (Migrated from github.com)

Hi, I would need an icon image to be inserted on this issue. Code is ready to be reviewed but I'm missing a second icon, I'm very bad at design, so if anyone can chime in, thanks a lot!
Fail url:
screenshot from 2018-07-27 17-53-10
Blank url
screenshot from 2018-07-27 17-53-21

Hi, I would need an icon image to be inserted on this issue. Code is ready to be reviewed but I'm missing a second icon, I'm very bad at design, so if anyone can chime in, thanks a lot! Fail url: ![screenshot from 2018-07-27 17-53-10](https://user-images.githubusercontent.com/3293616/43346123-6f106d80-91c6-11e8-95a4-f16f6a07fa90.png) Blank url ![screenshot from 2018-07-27 17-53-21](https://user-images.githubusercontent.com/3293616/43346127-71e09b20-91c6-11e8-9dc0-62cd7a188ac3.png)
tzarebczan commented 2018-08-06 18:50:30 +02:00 (Migrated from github.com)

Implemented on master via 1829, will be in next release.

Implemented on master via 1829, will be in next release.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1808
No description provided.