Minor UI issue: "Choose File" opens LBRY install folder on windows #1811

New issue

Open

opened 2018-07-24 17:50:28 +02:00 by LavRadis · 9 comments

LavRadis commented

2018-07-24 17:50:28 +02:00

(Migrated from github.com)

The Issue

On the first usage, the "Choose File" button in the "Publish" section opens in LBRY install directory. It could be confusing for new users. It could maybe open in "My documents" or "My computer". It remembers the last directory after the first time.

System Configuration

LBRY Daemon version: 0.20.4
LBRY App version: 0.23.0-rc.3
LBRY Installation ID: 7tYN144rHXrspzJG9xLP28fi1JztXnbpKro6DBJEQyzBmXTyDgqRLfYsUvHYFVmMe2
Operating system: Win 10

## The Issue On the first usage, the "Choose File" button in the "Publish" section opens in LBRY install directory. It could be confusing for new users. It could maybe open in "My documents" or "My computer". It remembers the last directory after the first time. ## System Configuration - LBRY Daemon version: 0.20.4 - LBRY App version: 0.23.0-rc.3 - LBRY Installation ID: 7tYN144rHXrspzJG9xLP28fi1JztXnbpKro6DBJEQyzBmXTyDgqRLfYsUvHYFVmMe2 - Operating system: Win 10

neb-b commented

2018-07-24 19:38:52 +02:00

(Migrated from github.com)

On mac it opens to the folder you chose from last time after clicking the button. I guess this isn't happening on windows? Must be an OS thing

tzarebczan commented

2018-07-24 19:47:29 +02:00

(Migrated from github.com)

Yes, that's true on windows also. But what happens when it's on a first run (no file previously selected)?

neb-b commented

2018-07-24 19:54:08 +02:00

(Migrated from github.com)

Seems like it's persisting between first runs. We might need to try on a new machine?

alyssaoc commented

2018-09-18 19:20:00 +02:00

(Migrated from github.com)

@tzarebczan Can you test to see if this is still happening?

tzarebczan commented

2018-09-18 19:23:59 +02:00

(Migrated from github.com)

This still happens, but only on first run and then it remembers the last location.

bcrowie commented

2020-06-08 18:53:13 +02:00

(Migrated from github.com)

I'd like to take this one on if that's alright.

neb-b commented

2020-06-08 19:03:59 +02:00

(Migrated from github.com)

@bcrowie It's all yours!

DispatchCommit commented

2021-01-27 12:51:08 +01:00

(Migrated from github.com)

Set defaultPath for the dialog.showOpenDialog() function: https://www.electronjs.org/docs/api/dialog#dialogshowopendialogbrowserwindow-options

You'd also likely need to detect which platform a user is on and/or use something like %HOMEPATH% to set it to the user's home profile (for windows at least).

The change is needed here: d04b0f09ba/ui/component/common/file-selector.jsx (L59)

(possibly in other locations, but this should at least give a head start in the right direction)

Set `defaultPath` for the `dialog.showOpenDialog()` function: https://www.electronjs.org/docs/api/dialog#dialogshowopendialogbrowserwindow-options You'd also likely need to detect which platform a user is on and/or use something like `%HOMEPATH%` to set it to the user's home profile (for windows at least). The change is needed here: https://github.com/lbryio/lbry-desktop/blob/d04b0f09ba2bc772d97fe32bfd66ec89786e3234/ui/component/common/file-selector.jsx#L59 (possibly in other locations, but this should at least give a head start in the right direction)

ByronEricPerez commented

2022-06-20 17:35:05 +02:00

(Migrated from github.com)

i'll be working on this ticket