Expose Full Screen setting in app #1815

Open
opened 2018-07-24 20:44:49 +02:00 by tzarebczan · 8 comments
tzarebczan commented 2018-07-24 20:44:49 +02:00 (Migrated from github.com)

The Issue

Some users may want to run the LBRY desktop app in full screen (i.e. pressing F11 while in the app). It would be a good idea to expose this setting somewhere in the app - settings page could be appropriate.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue Some users may want to run the LBRY desktop app in full screen (i.e. pressing F11 while in the app). It would be a good idea to expose this setting somewhere in the app - settings page could be appropriate. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
neb-b commented 2018-07-25 21:30:11 +02:00 (Migrated from github.com)

Is this idea "click this button to go full screen"?

Is this idea "click this button to go full screen"?
kauffj commented 2018-07-26 00:07:39 +02:00 (Migrated from github.com)

This is a good feature but Settings is probably the wrong place for it (or I'm misunderstanding)

This is a good feature but Settings is probably the wrong place for it (or I'm misunderstanding)
tzarebczan commented 2018-07-26 01:21:10 +02:00 (Migrated from github.com)

Believe this would be specific to Windows, as Mac already has a maximize option that works like this, and Linux users can move over the title bar to view the menu...and go to View > Toggle Full Screen.

On Windows, the menu bar is hidden by default. Maybe we can add a minimalistic one like Slack has: https://www.screencast.com/t/9tJgM3iRCA - might be possible with https://www.npmjs.com/package/electron-titlebar

Believe this would be specific to Windows, as Mac already has a maximize option that works like this, and Linux users can move over the title bar to view the menu...and go to View > Toggle Full Screen. On Windows, the menu bar is hidden by default. Maybe we can add a minimalistic one like Slack has: https://www.screencast.com/t/9tJgM3iRCA - might be possible with https://www.npmjs.com/package/electron-titlebar
kauffj commented 2018-08-01 17:23:59 +02:00 (Migrated from github.com)

@tzarebczan what does Discord do on Windows?

@tzarebczan what does Discord do on Windows?
tzarebczan commented 2018-08-01 18:39:55 +02:00 (Migrated from github.com)

Doesn't look like they expose a setting, but ctrl-shift-F forces it (not well documented)

Doesn't look like they expose a setting, but ctrl-shift-F forces it (not well documented)
CJorwinJ commented 2018-10-13 14:49:31 +02:00 (Migrated from github.com)

So is this still the same box?
< div id = " electron-titlebar " class = " inset " > < / div >

So is this still the same box? < div id = " electron-titlebar " class = " inset " > < / div >
neb-b commented 2018-10-15 18:17:24 +02:00 (Migrated from github.com)

@CJorwinJ Not sure what you mean.

@CJorwinJ Not sure what you mean.
poyaque-estamos commented 2021-02-13 18:13:34 +01:00 (Migrated from github.com)

Something like this?

image

Something like this? ![image](https://user-images.githubusercontent.com/9201183/107856241-28124d00-6e27-11eb-9620-66f6ecfd20e1.png)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1815
No description provided.