get recommended videos from search based on title #1845

Merged

neb-b merged 7 commits from next-video into master

2018-08-13 05:01:39 +02:00

neb-b commented

2018-08-02 05:34:25 +02:00

(Migrated from github.com)

tzarebczan commented

2018-08-03 23:23:06 +02:00

(Migrated from github.com)

3 things I noticed:

the URL is missing from the search bar when you go into it the first time. It comes back the next time you re-enter.
if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
I noticed the play button black > green (takes about a second or two) - can we speed this up? Why does it happen at all?

3 things I noticed: 1) the URL is missing from the search bar when you go into it the first time. It comes back the next time you re-enter. 2) if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue . 3) I noticed the play button black > green (takes about a second or two) - can we speed this up? Why does it happen at all?

neb-b commented

2018-08-07 07:39:18 +02:00

(Migrated from github.com)

@tzarebczan
issue 1 will be fixed with https://github.com/lbryio/lbry-redux/pull/65
Still thinking about how I can fix issue 2
issue 3 seems to exist on previous versions. Nothing from this PR should mess with that (it is definitely a valid issue though)

@tzarebczan issue 1 will be fixed with https://github.com/lbryio/lbry-redux/pull/65 Still thinking about how I can fix issue 2 issue 3 seems to exist on previous versions. Nothing from this PR should mess with that (it is definitely a valid issue though)

neb-b commented

2018-08-09 18:42:53 +02:00

(Migrated from github.com)

@skhameneh This is ready for review. There are still two issues but I would like to get this merged now so we can get some more eyes on it since I changed a lot of styles across the app.

Known issues:

if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
https://github.com/lbryio/lighthouse/issues/101

@skhameneh This is ready for review. There are still two issues but I would like to get this merged now so we can get some more eyes on it since I changed a lot of styles across the app. Known issues: - if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue . - https://github.com/lbryio/lighthouse/issues/101

skhameneh (Migrated from github.com) approved these changes 2018-08-10 15:06:03 +02:00