User history #1846

Merged

daovist merged 17 commits from user-history into master

2018-09-07 07:21:38 +02:00

daovist commented

2018-08-02 16:59:33 +02:00

(Migrated from github.com)

See #1009

Requires /lbryio/lbry-redux/pull/64

structures media playback position data by state.content.[claimId][outpoint] rather than state.media[outpoint]--this will useful down the road when we handle file updates
remove duplicated data representing a paused file
use changes to state.content.playingUri to pause video on file opening rather than state.media.paused
fix UI to not show layover after pausing from opening a file?
record user history browsing /show pages
add <UserHistoryPage> to display a paginated history list with "last viewed" info
add resume icons to <FileTile>s
add delete icon to <FileTile>s shown on <UserHistoryPage>
style page and tiles

See #1009 Requires [/lbryio/lbry-redux/pull/64](https://github.com/lbryio/lbry-redux/pull/64) - [x] structures media playback position data by `state.content.[claimId][outpoint]` rather than `state.media[outpoint]`--this will useful down the road when we handle file updates - [x] remove duplicated data representing a paused file - [x] use changes to `state.content.playingUri` to pause video on file opening rather than `state.media.paused` - [ ] fix UI to not show layover after pausing from opening a file? - [x] record user history browsing `/show` pages - [x] add `<UserHistoryPage>` to display a paginated history list with "last viewed" info - [x] add resume icons to `<FileTile>`s - [x] add delete icon to `<FileTile>`s shown on `<UserHistoryPage>` - [ ] style page and tiles

🎉 1

skhameneh (Migrated from github.com) reviewed 2018-08-02 16:59:33 +02:00

neb-b (Migrated from github.com) reviewed 2018-08-02 19:05:56 +02:00

neb-b (Migrated from github.com) left a comment

I will do a more in-depth look at the code but it looks pretty good.

I think this page should be a table view, similar to history pages on browsers. That way we don't have to remove content like the channel name. I think we can use the generic table style.

I will do a more in-depth look at the code but it looks pretty good. I think this page should be a table view, similar to history pages on browsers. That way we don't have to remove content like the channel name. I think we can use the generic table style.

src/renderer/component/fileCard/view.jsx

neb-b (Migrated from github.com) commented

2018-08-02 18:04:25 +02:00

Looks like you lost the FilePrice after I moved it in another PR

Looks like you lost the `FilePrice` after I moved it in another PR

neb-b commented

2018-08-02 19:08:55 +02:00

(Migrated from github.com)

I don't think we need the thumbnail in this view since they would have already seen it when actually navigating to it.

I don't think we need to do the select multiple feature right now, but maybe a button at the top to Delete all history

<img width="400" alt="screen shot 2018-08-02 at 1 07 47 pm" src="https://user-images.githubusercontent.com/16882830/43599290-1fe70a3c-9655-11e8-9518-d881dc788fe9.png"> I don't think we need the thumbnail in this view since they would have already seen it when actually navigating to it. I don't think we need to do the `select multiple` feature right now, but maybe a button at the top to `Delete all history`

neb-b commented

2018-09-04 19:29:31 +02:00

(Migrated from github.com)

@daovist @skhameneh This is ready for review. I would appreciate some testing, most of the data logic from travis' work stayed, I just changed the ui a bit.

daovist commented

2018-09-04 22:49:36 +02:00

(Migrated from github.com)

I am busy so I only looked at some of the code but the UI looks good. react-pagination is most excellent.

I might add a little padding to the top of the darker area but that's not a big deal. Alternating colors (ever so slightly) per item might be nice too, or a hover color change.

I am busy so I only looked at some of the code but the UI looks good. `react-pagination` is most excellent. I might add a little padding to the top of the darker area but that's not a big deal. Alternating colors (ever so slightly) per item might be nice too, or a hover color change.

neb-b commented

2018-09-07 07:21:21 +02:00

(Migrated from github.com)

@skhameneh

The app currently doesn't work with the latest lbry-redux because I removed the selectNavLinks function. Since we have a community PR with lbry-redux changes I'm going to merge this, so they can get the app to build properly. I will open another PR if needed to address any comments you have.

@skhameneh The app currently doesn't work with the latest `lbry-redux` because I removed the `selectNavLinks` function. Since we have a community PR with `lbry-redux` changes I'm going to merge this, so they can get the app to build properly. I will open another PR if needed to address any comments you have.