Play more file types #185

Merged
6ea86b96 merged 4 commits from play-more-file-types into master 2017-06-02 14:56:22 +02:00
6ea86b96 commented 2017-06-02 10:16:58 +02:00 (Migrated from github.com)

A couple of things in this PR @kauffj

Small tweaks:

  • Scroll to the top of the page when changing path. This was really irritating me.
  • Syncing up the loading status between the file actions and the video player. Can't click download on file actions when you're already loading from player and vice versa.

Big change:

  • Use render-media to also render images and audio files (should also be able to do documents at some point too). I think it might be cool to rename all the Video stuff to Media soon too.

Images have a folder icon which renders on click. Audio renders an HTML5 audio tag below the thumbnail image. Not all audio types are seekable.

filetypes

Perhaps we could render a waveform style player instead later on, and maybe an audio visualization instead of the thumbnail.

I think it would be awesome to make the media player stuff available on all pages. IMO it would be great if you could start something playing and it keeps playing at the bottom of the screen while you navigate around the app. Maybe with an option in the UI to add items to a playlist in the state

A couple of things in this PR @kauffj Small tweaks: - Scroll to the top of the page when changing path. This was really irritating me. - Syncing up the loading status between the file actions and the video player. Can't click download on file actions when you're already loading from player and vice versa. Big change: - Use render-media to also render images and audio files (should also be able to do documents at some point too). I think it might be cool to rename all the `Video` stuff to `Media` soon too. Images have a folder icon which renders on click. Audio renders an HTML5 audio tag below the thumbnail image. Not all audio types are seekable. ![filetypes](https://cloud.githubusercontent.com/assets/20863631/26717107/5948c936-47a6-11e7-975c-8f4853c9afb3.gif) Perhaps we could render a waveform style player instead later on, and maybe an audio visualization instead of the thumbnail. I think it would be awesome to make the media player stuff available on all pages. IMO it would be great if you could start something playing and it keeps playing at the bottom of the screen while you navigate around the app. Maybe with an option in the UI to add items to a playlist in the state
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#185
No description provided.