Load subscription data on app startup #1852

Closed
opened 2018-08-03 00:19:32 +02:00 by tzarebczan · 3 comments
tzarebczan commented 2018-08-03 00:19:32 +02:00 (Migrated from github.com)

The Issue

Currently, we don't check the API or load subscription data until the user subscribes to something or visits the subscriptions page. This should be loaded on startup instead.

Side effect: Clearing cache or logging into a new PC with old account will result in a subscription 101 notification if you subscribe to something before visiting the subscription page.

Thanks @ceogear for finding this one!

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue Currently, we don't check the API or load subscription data until the user subscribes to something or visits the subscriptions page. This should be loaded on startup instead. Side effect: Clearing cache or logging into a new PC with old account will result in a subscription 101 notification if you subscribe to something before visiting the subscription page. Thanks @ceogear for finding this one! ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
kauffj commented 2018-08-03 16:02:52 +02:00 (Migrated from github.com)

@daovist probably easy to roll into current sub work?

@daovist probably easy to roll into current sub work?
daovist commented 2018-08-06 20:08:02 +02:00 (Migrated from github.com)

Yes, this is going in my subscriptions epic.

Yes, this is going in my subscriptions epic.
tzarebczan commented 2018-08-21 17:05:19 +02:00 (Migrated from github.com)
Completed and confirmed in https://github.com/lbryio/lbry-desktop/pull/1872
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1852
No description provided.