Subscription page doesn't load if a channel has no claims or is abandoned #1884

Closed
opened 2018-08-15 23:00:52 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2018-08-15 23:00:52 +02:00 (Migrated from github.com)

The Issue

A couple of users ran into an issue where the subscription page was showing blank. Tracked the root cause down to either a subbed channel that's blank, or a subbed channel that no longer resolves (is abandoned). The claims_list_by_channel call is continued repeatedly for the said channel.

For the abandoned channel scenario - do we want to remove the channel via the subscription api call or should we be setting a new flag for deleted channels (so they don't try to be resolved again)?

Most likely related to this: 1c55774165/src/renderer/page/subscriptions/view.jsx (L46)

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue A couple of users ran into an issue where the subscription page was showing blank. Tracked the root cause down to either a subbed channel that's blank, or a subbed channel that no longer resolves (is abandoned). The claims_list_by_channel call is continued repeatedly for the said channel. For the abandoned channel scenario - do we want to remove the channel via the subscription api call or should we be setting a new flag for deleted channels (so they don't try to be resolved again)? Most likely related to this: https://github.com/lbryio/lbry-desktop/blob/1c55774165bb52f4509577d2739cd18ba6a85070/src/renderer/page/subscriptions/view.jsx#L46 ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
tzarebczan commented 2018-08-20 15:28:25 +02:00 (Migrated from github.com)

We should get this fixed along with the subscriptions overhaul. I cleaned up a few records I knew were causing issues.

We should get this fixed along with the subscriptions overhaul. I cleaned up a few records I knew were causing issues.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1884
No description provided.