Handle subscriptions where multiple claims posted in short period or when app is closed #1915

Closed
opened 2018-08-28 18:54:58 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2018-08-28 18:54:58 +02:00 (Migrated from github.com)

The Issue

Currently, the subscriptions process is only able to handle 1 piece of new content that's posted either in the same block, or within the interval the internal that the app checks for new subscriptions (15 minutes).

There are 2 scenarios:

  1. The app is running and these new claims come in
  2. The app was closed while the claims were posted, and then opened (this applies to all new content, not only ones posted in the same block)

For scenario 1, I'd expect that the app would try to download each piece of new content, but I could be convinced otherwise if we properly inform the user.

Scenario 2 is a bit trickier since there might be tons of new content since a user last ran the app, which would cause many downloads to start if we went all the way back to the point when the user last ran the app. In this scenario, we may want to download the single latest (or maybe up to some value) and alert the user that there are others posted, but not downloaded (and give an option to download?).

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue Currently, the subscriptions process is only able to handle 1 piece of new content that's posted either in the same block, or within the interval the internal that the app checks for new subscriptions (15 minutes). There are 2 scenarios: 1) The app is running and these new claims come in 2) The app was closed while the claims were posted, and then opened (this applies to all new content, not only ones posted in the same block) For scenario 1, I'd expect that the app would try to download each piece of new content, but I could be convinced otherwise if we properly inform the user. Scenario 2 is a bit trickier since there might be tons of new content since a user last ran the app, which would cause many downloads to start if we went all the way back to the point when the user last ran the app. In this scenario, we may want to download the single latest (or maybe up to some value) and alert the user that there are others posted, but not downloaded (and give an option to download?). ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
kauffj commented 2018-08-29 17:57:11 +02:00 (Migrated from github.com)

If I can't reliably use subscriptions to see every piece of content from a creator since the time I subscribed, then this is a bug.

If I can't reliably use subscriptions to see every piece of content from a creator since the time I subscribed, then this is a bug.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1915
No description provided.