Any special character before, after or within a url breaks the app #1927

Closed
opened 2018-08-31 05:02:57 +02:00 by ceoger · 4 comments
ceoger commented 2018-08-31 05:02:57 +02:00 (Migrated from github.com)

The Issue

when you include any special character like : (,./';][?":) within a claim url, it breaks the app

Steps to Reproduce

  1. Click on any video,
  2. once your get url in the address bar, add any special character like say , period "."
  3. press enter and you get a blank screen

Expected Behaviour

when a special character is added to the url, nothing should happen, a warning, or a search results for relevant url

Actual Behaviour

app turns blank

Suggested Solutions

Tell us your suggested solutions if you have any.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

https://cdn.discordapp.com/attachments/363049604461232148/484813043444744212/unknown.png

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue when you include any special character like : (,./';][?":) within a claim url, it breaks the app ### Steps to Reproduce 1. Click on any video, 2. once your get url in the address bar, add any special character like say , period "." 3. press enter and you get a blank screen ### Expected Behaviour when a special character is added to the url, nothing should happen, a warning, or a search results for relevant url ### Actual Behaviour app turns blank ### Suggested Solutions Tell us your suggested solutions if you have any. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> https://cdn.discordapp.com/attachments/363049604461232148/484813043444744212/unknown.png
neb-b commented 2018-08-31 05:24:15 +02:00 (Migrated from github.com)

Yep able to reproduce. Nice find @ceoger

Yep able to reproduce. Nice find @ceoger
tzarebczan commented 2018-08-31 06:07:20 +02:00 (Migrated from github.com)

To be clear, it's when it's added to the claim ID portion. The app handles the scenario where bad characters are present in the claim name.

To be clear, it's when it's added to the claim ID portion. The app handles the scenario where bad characters are present in the claim name.
ceoger commented 2018-08-31 10:49:56 +02:00 (Migrated from github.com)

it happens also in then url as well: "lbry://real-life-cryptocurrency-purchase-and.." as well as the claim ID portion

it happens also in then url as well: "lbry://real-life-cryptocurrency-purchase-and.." as well as the claim ID portion
tzarebczan commented 2018-10-11 22:28:20 +02:00 (Migrated from github.com)
Fixed in https://github.com/lbryio/lbry-desktop/pull/2026
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1927
No description provided.