fix: inconsistent thumbnail size on the publish page #1930

Merged
neb-b merged 1 commit from thumbnail-fix into master 2018-09-03 02:09:51 +02:00
neb-b commented 2018-09-02 03:51:13 +02:00 (Migrated from github.com)

I decided to zoom in on thumbnails if they aren't the proper aspect ratio, if we render the thumbnails as is, there are a ton of content items with incorrectly sized thumbnails. This results in a lot of content with black bars on the side. I think zooming in on some images is preferable.

Before

screen shot 2018-09-01 at 9 51 41 pm

After

This is how we were displaying the thumbnails in the app aready. This PR just makes it consistent on the publish page.

screen shot 2018-09-01 at 9 52 27 pm
I decided to zoom in on thumbnails if they aren't the proper aspect ratio, if we render the thumbnails as is, there are a ton of content items with incorrectly sized thumbnails. This results in a lot of content with black bars on the side. I think zooming in on some images is preferable. ### Before <img width="400" alt="screen shot 2018-09-01 at 9 51 41 pm" src="https://user-images.githubusercontent.com/16882830/44951405-417ad680-ae31-11e8-8700-e2472e765911.png"> ### After This is how we were displaying the thumbnails in the app aready. This PR just makes it consistent on the publish page. <img width="400" alt="screen shot 2018-09-01 at 9 52 27 pm" src="https://user-images.githubusercontent.com/16882830/44951406-55bed380-ae31-11e8-98e4-43f654ec7794.png">
skhameneh (Migrated from github.com) approved these changes 2018-09-03 02:08:23 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1930
No description provided.