Better messaging for takeover amounts on publish page #1940

2018-09-07T05:45:14+02:00

neb-b commented

2018-09-07 05:45:14 +02:00

(Migrated from github.com)

More clarity for takeover amounts on claims

Show amount needed to win a claim when editing. Ex: "You have a claim at xxx, for 5 more LBC you will control it"

Changes

I created a new component NameHelpText for variable help text under the name input. I moved BidHelpText under the bid input (which is probably where it should have been in the first place)

Before

After

More clarity for takeover amounts on claims Show amount needed to win a claim when editing. Ex: "You have a claim at xxx, for 5 more LBC you will control it" ### Changes I created a new component `NameHelpText` for variable help text under the name input. I moved `BidHelpText` under the bid input (which is probably where it should have been in the first place) #### Before <img width="400" alt="screen shot 2018-09-24 at 8 24 53 pm" src="https://user-images.githubusercontent.com/16882830/45986181-ec00a680-c037-11e8-839e-41da36a50682.png"> #### After <img width="400" alt="screen shot 2018-09-24 at 8 23 39 pm" src="https://user-images.githubusercontent.com/16882830/45986164-c96e8d80-c037-11e8-866a-00b1fd8d6852.png">

tzarebczan (Migrated from github.com) reviewed 2018-09-09 01:36:30 +02:00

src/renderer/component/publishForm/internal/bid-help-text.jsx

tzarebczan (Migrated from github.com) commented

2018-09-09 01:36:30 +02:00

Is "win" the right word here? Maybe control or mention vanity? We use it in a few places...

tzarebczan (Migrated from github.com) reviewed 2018-09-09 01:37:14 +02:00

src/renderer/component/publishForm/internal/bid-help-text.jsx

tzarebczan (Migrated from github.com) commented

2018-09-09 01:37:14 +02:00

I'm assuming you'll add this back in :)

neb-b (Migrated from github.com) reviewed 2018-09-09 01:38:18 +02:00

src/renderer/component/publishForm/internal/bid-help-text.jsx

neb-b (Migrated from github.com) commented

2018-09-09 01:38:18 +02:00

I like control. I think we can definitely improve this copy.

neb-b (Migrated from github.com) reviewed 2018-09-09 01:38:37 +02:00

src/renderer/component/publishForm/internal/bid-help-text.jsx

neb-b (Migrated from github.com) commented

2018-09-09 01:38:37 +02:00

Yes. This PR still needs a lot of cleanup.

neb-b commented

2018-09-17 17:57:13 +02:00

(Migrated from github.com)

@tzarebczan I think this is working correctly. Before cleaning up/renaming stuff could you give this a test?

I'm open to adding new messages/re-wording it but I mainly want to see if it's working.

How it should work:

uri on publish page:
lbry://@sean/sean

messages:
A deposit greater than 1.234 is needed to control lbry://sean
Any amount will let you control lbry://@sean/sean

If there is no channel in the uri:

uri on publish  page:
lbry://sean

messages:
A deposit greater than 1.234 is needed to control lbry://sean

If there are no matches for the short uri or uri with channel:

uri on publish page:
lbry://@somerandomchannel/somerandomclaim

messages:
Any amount will let you control lbry://somerandomclaim
Any amount will let you control lbry://@somerandomchannel/somerandomclaim

@tzarebczan I think this is working correctly. Before cleaning up/renaming stuff could you give this a test? I'm open to adding new messages/re-wording it but I mainly want to see if it's working. How it should work: ``` uri on publish page: lbry://@sean/sean messages: A deposit greater than 1.234 is needed to control lbry://sean Any amount will let you control lbry://@sean/sean ``` If there is no channel in the uri: ``` uri on publish page: lbry://sean messages: A deposit greater than 1.234 is needed to control lbry://sean ``` If there are no matches for the short uri or uri with channel: ``` uri on publish page: lbry://@somerandomchannel/somerandomclaim messages: Any amount will let you control lbry://somerandomclaim Any amount will let you control lbry://@somerandomchannel/somerandomclaim ```

tzarebczan commented

2018-09-19 17:02:18 +02:00

(Migrated from github.com)

the messaging about both urls in the last case might be confusing, I think it's enough only to tell them Any amount will let you control lbry://somerandomclaim - what do you think?

Any amount will let you control lbry://@sean/sean what if someone takes over @sean?

I still haven't run through it, will give that a shot today.

the messaging about both urls in the last case might be confusing, I think it's enough only to tell them `Any amount will let you control lbry://somerandomclaim` - what do you think? `Any amount will let you control lbry://@sean/sean` what if someone takes over @sean? I still haven't run through it, will give that a shot today.

neb-b commented

2018-09-19 17:56:58 +02:00

(Migrated from github.com)

I think it would be ok to only show the short url

tzarebczan commented

2018-09-21 17:14:26 +02:00

(Migrated from github.com)

@seanyesmunt we also discussed showing vanity top bids when editing claims as part of this PR.

neb-b commented

2018-09-24 19:22:38 +02:00

(Migrated from github.com)

@tzarebczan Added that to the PR description for documentation

neb-b commented

2018-09-25 02:25:46 +02:00

(Migrated from github.com)

@tzarebczan Still working on the exact wording for these messages, but I think this is ready to be tested.

skhameneh (Migrated from github.com) approved these changes 2018-09-26 03:29:04 +02:00

src/renderer/component/publishForm/internal/name-help-text.jsx

					
				@ -0,0 +28,4 @@

				      });

				      nameHelpText = (

				        <React.Fragment>

skhameneh (Migrated from github.com) commented

2018-09-26 03:28:20 +02:00

Can also use the short syntax (empty tags):

<>
  {/* markup here */}
</>

Can also use the short syntax (empty tags): ``` <> {/* markup here */} </> ```

neb-b (Migrated from github.com) reviewed 2018-09-26 19:39:36 +02:00

src/renderer/component/publishForm/internal/name-help-text.jsx

					
				@ -0,0 +28,4 @@

				      });

				      nameHelpText = (

				        <React.Fragment>

neb-b (Migrated from github.com) commented

2018-09-26 19:39:36 +02:00

Do we need to do something with webpack for that to work? Doesn't seem to build properly when I do that.

tzarebczan commented

2018-10-01 02:35:04 +02:00

(Migrated from github.com)

If you bid more than 110082.30000001 LBC, when somone navigates to lbry://one it will load your published content.
How can we make it clearer that they can still publish to this URL and have their content at the exact URL? We can't show them the claim id because it's not known until the transaction is created.

(just noticed the misspelling on someone)

`If you bid more than 110082.30000001 LBC, when somone navigates to lbry://one it will load your published content.` How can we make it clearer that they can still publish to this URL and have their content at the exact URL? We can't show them the claim id because it's not known until the transaction is created. (just noticed the misspelling on `someone`)

neb-b commented

2018-10-01 04:47:18 +02:00

(Migrated from github.com)

@tzarebczan "However, you can get a longer version of this URL for any price"?

tzarebczan commented

2018-10-01 18:48:52 +02:00

(Migrated from github.com)

"However, you can get a longer version of this URL for any bid"?

👍 1

tzarebczan commented

2018-10-01 18:49:33 +02:00

(Migrated from github.com)