refactors and enhances tip modal #1964

Merged

jessopb merged 1 commit from tiplogic into master

2018-09-20 02:29:12 +02:00

jessopb commented

2018-09-13 03:04:20 +02:00

(Migrated from github.com)

Tip modal now disables send button on all invalid actions and shows feedback.

Tip modal now disables send button on all invalid actions and shows feedback. ![tip_](https://user-images.githubusercontent.com/36554050/45460960-63e0df80-b6ce-11e8-93d5-cd465dc31349.png) ![tipequalsbalance](https://user-images.githubusercontent.com/36554050/45460961-63e0df80-b6ce-11e8-9007-77830c008bf0.png) ![tipgreaterthanbalance](https://user-images.githubusercontent.com/36554050/45460962-63e0df80-b6ce-11e8-939e-39ee8a2a8e06.png) ![tipmanydots](https://user-images.githubusercontent.com/36554050/45460963-63e0df80-b6ce-11e8-8255-d75d9b77c7c3.png) ![tipmaxdecimal](https://user-images.githubusercontent.com/36554050/45460964-64797600-b6ce-11e8-9f91-0b747c802b96.png) ![tippointfive](https://user-images.githubusercontent.com/36554050/45460965-64797600-b6ce-11e8-93c8-fbe693f901c2.png) ![tiptoomanydecimals](https://user-images.githubusercontent.com/36554050/45460966-64797600-b6ce-11e8-9694-3e87707c659a.png) ![tiptwenty](https://user-images.githubusercontent.com/36554050/45460967-64797600-b6ce-11e8-8981-7cb20efae711.png)

neb-b (Migrated from github.com) requested changes 2018-09-13 21:32:25 +02:00

neb-b (Migrated from github.com) left a comment

This looks good. There is one bug I see where if I type a small number I see scientific notation. We should avoid this.

This looks good. There is one bug I see where if I type a small number I see scientific notation. We should avoid this. <img width="400" alt="screen shot 2018-09-13 at 3 31 37 pm" src="https://user-images.githubusercontent.com/16882830/45511167-334e8380-b76a-11e8-9c2a-6e80006538e9.png">

jessopb commented

2018-09-14 10:12:54 +02:00

(Migrated from github.com)

Oh, I remember noticing that before. Modification on line 85.

kauffj commented

2018-09-14 20:42:07 +02:00

(Migrated from github.com)

Not strictly necessary, but splitting the "tip must be a valid number with no more than 8 decimals places" into more messages would improve UX:

"Tip must be a number" (shown if anything other than a number is entered - can also drop valid, it conveys no additional information)
"Tip must be positive" (I've now deduced what was meant by the word valid)
"Tip must not be more than 8 decimal places" (shown if a 9+ decimal number is entered)

Not strictly necessary, but splitting the "tip must be a valid number with no more than 8 decimals places" into more messages would improve UX: - "Tip must be a number" (shown if anything other than a number is entered - can also drop valid, it conveys no additional information) - "Tip must be positive" (I've now deduced what was meant by the word valid) - "Tip must not be more than 8 decimal places" (shown if a 9+ decimal number is entered)

👍 1

jessopb commented

2018-09-14 22:32:24 +02:00

(Migrated from github.com)

I hear you. I'm glad to get specific input on the actual messages.
I'll have something shortly.

I hear you. I'm glad to get specific input on the actual messages. I'll have something shortly.

jessopb commented

2018-09-15 00:48:00 +02:00

(Migrated from github.com)

I'm noticing this functionality duplicated in 3 places: Publish>deposit, page>file>...>walletSendTip, and Wallet>walletSend. All three are basically the same FormField that informs a button to be disabled. The form field could stand to be wider as well, I think. Thoughts? Make it component?

neb-b commented

2018-09-17 15:30:37 +02:00

(Migrated from github.com)

I think making the input/label into it's own component sounds like a great idea!

tzarebczan commented

2018-09-19 17:18:15 +02:00

(Migrated from github.com)

@jessopb any updates here? Will the last comments also occur in this PR or a separate one?

jessopb commented

2018-09-20 00:30:39 +02:00

(Migrated from github.com)

The latest commit does precisely what @kauffj suggests.