LBRYCommunity/lbry-desktop

Smart tooltip #1979

Merged

btzr-io merged 4 commits from tooltip into master

2018-09-25 02:43:08 +02:00

btzr-io commented

2018-09-24 00:11:24 +02:00

(Migrated from github.com)

Changes

Make tooltip smarter #1978

### Changes - Make tooltip smarter #1978

neb-b (Migrated from github.com) requested changes 2018-09-24 21:09:13 +02:00

src/renderer/component/common/tooltip.jsx

					
				@ -19,0 +69,4 @@

				    const visibility = this.getVisibility();

				    // Invert direction if tooltip is outside viewport bounds

				    if (!visibility[direction]) {

neb-b (Migrated from github.com) commented

2018-09-24 21:09:09 +02:00

Could you add a short comment above this explaining why we might need to invert? The code is very readable but it wouldn't hurt to add some additional explanation.

Could you add a short comment above this explaining why we might need to invert? The code is very readable but it wouldn't hurt to add some additional explanation.

btzr-io commented

2018-09-25 01:20:34 +02:00

(Migrated from github.com)

@seanyesmunt ok done 👍

@seanyesmunt ok done :+1:

neb-b (Migrated from github.com) approved these changes 2018-09-25 02:43:01 +02:00

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1979

No description provided.