Transactions filter menu collides with transaction table #2000

New issue

Closed

opened 2018-10-04 04:44:25 +02:00 by neb-b · 8 comments

neb-b commented

2018-10-04 04:44:25 +02:00

(Migrated from github.com)

The Issue

Transactions filter menu collides with transaction table on small screens. This must have happened after https://github.com/lbryio/lbry-desktop/pull/1985 was merged.

Steps to Reproduce

View transactions page
Shrink screen until the filter menu overlaps with the table

Suggested Solutions

It currently uses position: absolute to achieve the positioning. Ideally the filter menu should just appear first in the dom so we don't need to hoist it up.

It should probably be in line with the title, just moved over to the right side.

## The Issue Transactions filter menu collides with transaction table on small screens. This must have happened after https://github.com/lbryio/lbry-desktop/pull/1985 was merged. ### Steps to Reproduce 1. View transactions page 2. Shrink screen until the filter menu overlaps with the table <img width="400" alt="screen shot 2018-10-03 at 10 41 18 pm" src="https://user-images.githubusercontent.com/16882830/46450124-ae99c880-c75d-11e8-83fd-403f4261249d.png"> ### Suggested Solutions It currently uses `position: absolute` to achieve the positioning. Ideally the filter menu should just appear first in the dom so we don't need to hoist it up. It should probably be in line with the title, just moved over to the right side.

estevanjantsk commented

2018-10-04 05:23:20 +02:00

(Migrated from github.com)

@seanyesmunt something like that? Thanks!

<img width="600" alt="captura de tela 2018-10-04 as 00 22 43" src="https://user-images.githubusercontent.com/461342/46451252-a34d9980-c76b-11e8-8ebd-f1fd719a424b.png"> @seanyesmunt something like that? Thanks!

neb-b commented

2018-10-04 05:26:53 +02:00

(Migrated from github.com)

Hey @estevanjantsk! I think it would be better if it was inline with the Transaction History title. I added some additional info to the issue description

Hey @estevanjantsk! I think it would be better if it was inline with the `Transaction History` title. I added some additional info to the issue description

estevanjantsk commented

2018-10-04 05:29:05 +02:00

(Migrated from github.com)

nice! I'll try that one 👍

neb-b commented

2018-10-04 05:29:45 +02:00

(Migrated from github.com)

Awesome! Let me know if you have any more questions 🙂

ykris45 commented

2018-10-04 19:15:28 +02:00

(Migrated from github.com)

@seanyesmunt i tested it with position relative and the Transactions filter menu uncolides

ykris45 commented

2018-10-10 17:12:36 +02:00

(Migrated from github.com)

close close..hehehe @seanyesmunt

neb-b commented

2018-10-10 18:40:33 +02:00

(Migrated from github.com)

@estevanjantsk We found a fix for this issue but I still think the solution we discussed would be preferable. If you are still working on it feel free to submit a PR!

neb-b commented

2018-10-17 00:00:30 +02:00

(Migrated from github.com)

I'm going to close this for now