HTTP -> HTTPS #2015

Closed
opened 2018-10-05 22:21:12 +02:00 by nikooo777 · 3 comments
nikooo777 commented 2018-10-05 22:21:12 +02:00 (Migrated from github.com)

The Issue

HTTP is bad

Steps to Reproduce

  1. Travel in time from the past to 2018
  2. Find out about sniffing, tampering, mitm and all the horrible things that are possible on http
  3. panic

Expected Behaviour

We should use https where possible

Actual Behaviour

Some things don't

Suggested Solutions

add an s here:
e4f4909725/src/renderer/component/viewOnWebButton/view.jsx (L22)
a895617342/src/renderer/component/socialShare/view.jsx (L34-L35)
b77864230d/src/renderer/component/selectThumbnail/view.jsx (L92)

Screenshots

https://spee.ch/ee42d31a678720aec0e6f1417f2c462f5060a634/new-share-screen.jpg

## The Issue HTTP is bad ### Steps to Reproduce 1. Travel in time from the past to 2018 2. Find out about sniffing, tampering, mitm and all the horrible things that are possible on http 3. panic ### Expected Behaviour We should use https where possible ### Actual Behaviour Some things don't ### Suggested Solutions add an `s` here: https://github.com/lbryio/lbry-desktop/blob/e4f4909725f52c1eca8a4c4b707fd14a9f56576d/src/renderer/component/viewOnWebButton/view.jsx#L22 https://github.com/lbryio/lbry-desktop/blob/a895617342ee942362a22fede2ea556a7c42803b/src/renderer/component/socialShare/view.jsx#L34-L35 https://github.com/lbryio/lbry-desktop/blob/b77864230d4589f16cb7ab61c7811a640ca532da/src/renderer/component/selectThumbnail/view.jsx#L92 ## Screenshots https://spee.ch/ee42d31a678720aec0e6f1417f2c462f5060a634/new-share-screen.jpg
imjayanthka commented 2018-10-05 23:23:17 +02:00 (Migrated from github.com)

can i work on this?

can i work on this?
tzarebczan commented 2018-10-05 23:24:24 +02:00 (Migrated from github.com)

Go for it, should be an easy one :)

Go for it, should be an easy one :)
neb-b commented 2018-10-06 00:43:18 +02:00 (Migrated from github.com)

Thanks @imjayanthka! 🙂

Thanks @imjayanthka! 🙂
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2015
No description provided.