Add content placeholders and add time info to FileCard/FileTile #2022

2018-10-10T07:19:11+02:00

neb-b commented

2018-10-10 07:19:11 +02:00

(Migrated from github.com)

Changes

Added placeholder styles for all file cards and tiles (related content, search, channels)
Added the published date (based on block height) to every file card and tile
Added back the upgrades to the share modal (I accidentally removed it)

Pics

### Changes - Added placeholder styles for all file cards and tiles (related content, search, channels) - Added the published date (based on block height) to every file card and tile - Added back the upgrades to the share modal (I accidentally removed it) ### Pics <img width="400" alt="screen shot 2018-10-10 at 1 25 20 am" src="https://user-images.githubusercontent.com/16882830/46714827-6d0c9000-cc2b-11e8-98c3-804aeb80968f.png"> <img width="400" alt="screen shot 2018-10-10 at 1 18 33 pm" src="https://user-images.githubusercontent.com/16882830/46753886-07ea8600-cc8f-11e8-9c34-07bd191c54b6.png"> <img width="400" alt="screen shot 2018-10-10 at 1 25 34 am" src="https://user-images.githubusercontent.com/16882830/46714836-74339e00-cc2b-11e8-8cc3-59e80113c5e4.png">

neb-b (Migrated from github.com) reviewed 2018-10-10 07:20:32 +02:00

src/renderer/component/fileCard/view.jsx

neb-b (Migrated from github.com) commented

2018-10-10 07:20:31 +02:00

Should this be its own component? I'm not sure.

I think it could be helpful to see the classes that are used below to keep the layout consistent

Should this be its own component? I'm not sure. I think it could be helpful to see the classes that are used below to keep the layout consistent

skhameneh (Migrated from github.com) approved these changes 2018-10-12 20:32:26 +02:00

skhameneh (Migrated from github.com) left a comment

minor comments

src/renderer/component/fileCard/view.jsx

skhameneh (Migrated from github.com) commented

2018-10-12 20:29:55 +02:00

Doesn't contain a lot, do you expect to reuse this within other components?

skhameneh (Migrated from github.com) commented

2018-10-12 20:30:37 +02:00

I see similar below, but it's not the same.

src/renderer/component/fileTile/view.jsx

skhameneh (Migrated from github.com) commented

2018-10-12 20:31:26 +02:00

Why is this logic here? Seems it should be shared logic

src/renderer/scss/component/_placeholder.scss

					
				@ -0,0 +22,4 @@

				  height: 3em;

				}

				.placeholder__channel {

skhameneh (Migrated from github.com) commented

2018-10-12 20:32:09 +02:00

line break

neb-b (Migrated from github.com) reviewed 2018-10-12 20:34:41 +02:00

src/renderer/component/fileTile/view.jsx

neb-b (Migrated from github.com) commented

2018-10-12 20:34:41 +02:00

👍 We should probably use const { name } = parseUri(uri)

👍 We should probably use `const { name } = parseUri(uri)`

neb-b commented

2018-10-12 20:42:27 +02:00

(Migrated from github.com)

@skhameneh Can't respond to your comment inline, but I don't expect to use those placeholders in other components. They are very specific to FileCard/FileTile.

Sign in to join this conversation.

No reviewers

skhameneh