Flow type errors #2024

New issue

Open

opened 2018-10-10 19:03:40 +02:00 by neb-b · 5 comments

neb-b commented

2018-10-10 19:03:40 +02:00

(Migrated from github.com)

We are currently trying to use Flow in every file. We have been slowly making progress but there are still a lot of errors.

If you open a PR with some Flow error fixes (or anything else) we will send you some LBC as appreciation!

Some of the biggest offenders right now are in pages/file/view.jsx and anything with subscriptions.

To see all of the errors you can run ./node_modules/.bin/flow --color always

We are currently trying to use [Flow](https://flow.org/) in every file. We have been slowly making progress but there are still a lot of errors. If you open a PR with some Flow error fixes (or anything else) we will send you some LBC as appreciation! Some of the biggest offenders right now are in `pages/file/view.jsx` and anything with subscriptions. To see all of the errors you can run `./node_modules/.bin/flow --color always`

izanf commented

2018-10-10 21:39:12 +02:00

(Migrated from github.com)

I will work on this issue

lyvwhyr commented

2018-10-10 23:48:21 +02:00

(Migrated from github.com)

/request

neb-b commented

2018-10-10 23:52:10 +02:00

(Migrated from github.com)

@izanf and @feralCode there are a ton of issues that can be fixed. I would open a PR as you fix them (or leave another comment here) saying which component/file you are fixing so no work is duplicated.

chrisza4 commented

2018-10-11 18:15:37 +02:00

(Migrated from github.com)

While I am working on this issue, I also need to fix flow type error at publishForm/view.jsx. I am working on that file.

While I am working on this [issue](https://github.com/lbryio/lbry-desktop/issues/1839), I also need to fix flow type error at `publishForm/view.jsx`. I am working on that file.

🎉 1

dannycalleri commented

2018-10-21 10:44:59 +02:00

(Migrated from github.com)

Hi @seanyesmunt , I'm opening a PR to fix a few flow errors in these view.jsx files and some other connected:

        modified:   src/renderer/component/button/view.jsx
	modified:   src/renderer/component/cardVerify/view.jsx
	modified:   src/renderer/component/channelTile/view.jsx
	modified:   src/renderer/component/common/form-components/form-field.jsx

here's my PR: https://github.com/lbryio/lbry-desktop/issues/2024

Hi @seanyesmunt , I'm opening a PR to fix a few flow errors in these `view.jsx` files and some other connected: ``` modified: src/renderer/component/button/view.jsx modified: src/renderer/component/cardVerify/view.jsx modified: src/renderer/component/channelTile/view.jsx modified: src/renderer/component/common/form-components/form-field.jsx ``` here's my PR: https://github.com/lbryio/lbry-desktop/issues/2024