LBRYCommunity/lbry-desktop

Fork 0

Date #2036

Merged

TiagoKaska merged 4 commits from master into master

2018-10-14 22:13:08 +02:00

TiagoKaska commented

2018-10-14 18:37:43 +02:00

(Migrated from github.com)

add Reverse Order & Use System/Location Time/Date

neb-b commented

2018-10-14 19:17:20 +02:00

(Migrated from github.com)

@TiagoKaska Thanks for the PR! 🙂

Do you know if there is a time when we wouldn't want to use moment.locale(remote.app.getLocale())?

If not, maybe we should move that line to src/renderer/index.js to keep things consistent.

@TiagoKaska Thanks for the PR! 🙂 Do you know if there is a time when we wouldn't want to use `moment.locale(remote.app.getLocale())`? If not, maybe we should move that line to `src/renderer/index.js` to keep things consistent.

TiagoKaska commented

2018-10-14 19:23:36 +02:00

(Migrated from github.com)

@seanyesmunt I should be moving, Thanks

👍 1

TiagoKaska commented

2018-10-14 19:42:50 +02:00

(Migrated from github.com)

@seanyesmunt I can't remove console.log ? in file src/renderer/index.js :

21:20 error Absolute imports should come before relative imports import/first
69:9 warning Unexpected console statement no-console
161:7 warning Unexpected console statement no-console
164:7 warning Unexpected console statement no-console
167:7 warning Unexpected console statement no-console

@seanyesmunt I can't remove console.log ? in file src/renderer/index.js : 21:20 error Absolute imports should come before relative imports import/first 69:9 warning Unexpected console statement no-console 161:7 warning Unexpected console statement no-console 164:7 warning Unexpected console statement no-console 167:7 warning Unexpected console statement no-console

neb-b commented

2018-10-14 19:44:37 +02:00

(Migrated from github.com)

@TiagoKaska We can keep those. Maybe add /* eslint-disable no-console */ at the top of the file, then /* eslint-enable no-console */ at the bottom. That should disable it just for that file.

@TiagoKaska We can keep those. Maybe add `/* eslint-disable no-console */` at the top of the file, then `/* eslint-enable no-console */` at the bottom. That should disable it just for that file.

neb-b commented

2018-10-14 20:59:03 +02:00

(Migrated from github.com)

@TiagoKaska Great. Do you know if that affects any other dates? Maybe on the history page?

I'll give it a test too. Can you also add a changelog udpate?

@TiagoKaska Great. Do you know if that affects any other dates? Maybe on the history page? I'll give it a test too. Can you also add a [changelog](https://github.com/lbryio/lbry-desktop/blob/master/CHANGELOG.md) udpate?

TiagoKaska commented

2018-10-14 21:05:52 +02:00

(Migrated from github.com)

@seanyesmunt I noticed that it affects all the dates where the moment is used

> @seanyesmunt I noticed that it affects all the dates where the moment is used

neb-b commented

2018-10-14 22:13:04 +02:00

(Migrated from github.com)

I think it's ok, just tested and it looks fine. I'm guessing we should have been doing this already for dates that use moment. I'm going to merge this.

neb-b commented

2018-10-14 22:15:43 +02:00

(Migrated from github.com)

@TiagoKaska thanks for the contribution! If you haven't already, checkout our [contributing] (https://github.com/lbryio/lbry-desktop/blob/master/CONTRIBUTING.md) guide if you haven't yet (sorry I didn't send this to you when you first opened your PR.

Can we send you LBC in appreciation for your work?

👍 1

TiagoKaska commented

2018-10-14 22:57:29 +02:00

(Migrated from github.com)

thanks @seanyesmunt 👍
my wallet address bMEgg2vVvMi93MMdKdYH1uVKk7XfMVTYxm

thanks @seanyesmunt 👍 my wallet address bMEgg2vVvMi93MMdKdYH1uVKk7XfMVTYxm

alyssaoc commented

2018-10-15 22:28:44 +02:00

(Migrated from github.com)

@TiagoKaska Please follow the instructions at https://lbry.io/faq/appreciation, so we can sen you an appreciation. Thank you

👍 1