Fix issue file_list call continues indefinitely if a file is removed while downloading #2042
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#2042
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "file_list-call"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Based on this issue
Since when ACTIONS.FILE_DELETE dispatch in
lbry-redux
, we actually remove the outpoint from store. So in order to update status, it makes sense to check if the outpoint still exists first before we dispatch update.Also, centralized the update interval function.
Another one! Could you add a comment above
setNextStatusUpdate
saying why we need to check if outpoint exists? I think that would be helpful in the future. Then just add a changelog update and it's ready to merge.Thanks for checking out LBRY and the contribution! If you haven't already, please make sure to check out our contributors guide.
Can we send you LBC in appreciation for your work
Changelog updated, and also comment added.
Thanks for fixing the typo
@chrisza4 , please don't forget to reach out to us via email so we can get some LBC over to you and send you the form for the Hacktoberfest t-shirt.