Fix issue file_list call continues indefinitely if a file is removed while downloading #2042

Merged
chrisza4 merged 3 commits from file_list-call into master 2018-10-18 17:23:36 +02:00
chrisza4 commented 2018-10-15 13:30:05 +02:00 (Migrated from github.com)

Based on this issue

Since when ACTIONS.FILE_DELETE dispatch in lbry-redux, we actually remove the outpoint from store. So in order to update status, it makes sense to check if the outpoint still exists first before we dispatch update.

Also, centralized the update interval function.

Based on this [issue](https://github.com/lbryio/lbry-desktop/issues/1860) Since when ACTIONS.FILE_DELETE dispatch in `lbry-redux`, we actually remove the outpoint from store. So in order to update status, it makes sense to check if the outpoint still exists first before we dispatch update. Also, centralized the update interval function.
neb-b commented 2018-10-15 18:12:49 +02:00 (Migrated from github.com)

Another one! Could you add a comment above setNextStatusUpdate saying why we need to check if outpoint exists? I think that would be helpful in the future. Then just add a changelog update and it's ready to merge.

Another one! Could you add a comment above `setNextStatusUpdate` saying why we need to check if outpoint exists? I think that would be helpful in the future. Then just add a changelog update and it's ready to merge.
alyssaoc commented 2018-10-17 22:19:20 +02:00 (Migrated from github.com)

Thanks for checking out LBRY and the contribution! If you haven't already, please make sure to check out our contributors guide.
Can we send you LBC in appreciation for your work

Thanks for checking out LBRY and the contribution! If you haven't already, please make sure to check out our [contributors guide](https://lbry.tech/contribute). Can we send you [LBC in appreciation for your work](https://lbry.io/faq/appreciation)
chrisza4 commented 2018-10-18 14:39:00 +02:00 (Migrated from github.com)

Changelog updated, and also comment added.

Changelog updated, and also comment added.
neb-b (Migrated from github.com) reviewed 2018-10-18 17:21:22 +02:00
neb-b (Migrated from github.com) commented 2018-10-18 17:21:22 +02:00
        // If a file is already deleted, no point to still try update load status
```suggestion // If a file is already deleted, no point to still try update load status ```
chrisza4 commented 2018-10-21 06:33:49 +02:00 (Migrated from github.com)

Thanks for fixing the typo

Thanks for fixing the typo
tzarebczan commented 2018-10-29 21:17:03 +01:00 (Migrated from github.com)

@chrisza4 , please don't forget to reach out to us via email so we can get some LBC over to you and send you the form for the Hacktoberfest t-shirt.

@chrisza4 , please don't forget to reach out to us via email so we can get some LBC over to you and send you the form for the Hacktoberfest t-shirt.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2042
No description provided.