persists transaction filter: RE #1154 #2048

Merged

jessopb merged 2 commits from txListFilterPersist into master

2018-10-19 18:26:52 +02:00

jessopb commented

2018-10-18 06:00:59 +02:00

(Migrated from github.com)

DEPENDS ON: https://github.com/lbryio/lbry-redux/pull/84
ISSUE: https://github.com/lbryio/lbry-desktop/issues/1154
Filter choices in transaction list persist.

DEPENDS ON: https://github.com/lbryio/lbry-redux/pull/84 ISSUE: https://github.com/lbryio/lbry-desktop/issues/1154 Filter choices in transaction list persist.

👍 1

neb-b (Migrated from github.com) requested changes 2018-10-18 07:08:05 +02:00

neb-b (Migrated from github.com) left a comment

Just the change to add an "all" transaction type. To have this properly persist you will need to add a new redux filter like this: https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/store.js#L108

We only need to persist the filter setting from that reducer.

Other than that looks good! This will be great to have.

Just the change to add an `"all"` transaction type. To have this properly persist you will need to add a new redux filter like this: https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/store.js#L108 We only need to persist the filter setting from that reducer. Other than that looks good! This will be great to have.

src/renderer/component/transactionList/view.jsx

neb-b (Migrated from github.com) commented

2018-10-18 07:06:16 +02:00

After looking at this now, I think we should just add a new TRANSACTION value for "all" instead of referencing it in a couple places. Sorry for merging the lbry-redux PR before realizing this.

After looking at this now, I think we should just add a new `TRANSACTION` value for `"all"` instead of referencing it in a couple places. Sorry for merging the lbry-redux PR before realizing this.