Fixed flow errors on a few 'view.jsx' files and 'form-field.jsx' #2049

2018-10-21T11:01:11+02:00

dannycalleri commented

2018-10-21 11:01:11 +02:00

(Migrated from github.com)

Fixed a few flow errors, connected to this issue:
https://github.com/lbryio/lbry-desktop/issues/2024 .
Let me know what you think 🤘

Fixed a few flow errors, connected to this issue: https://github.com/lbryio/lbry-desktop/issues/2024 . Let me know what you think 🤘

🎉 1

neb-b (Migrated from github.com) requested changes 2018-10-21 20:28:13 +02:00

neb-b (Migrated from github.com) left a comment

Thanks for the PR! 🙂

Just one minor issue then it looks good.

Thanks for the PR! 🙂 Just one minor issue then it looks good.

src/renderer/component/channelTile/view.jsx

					
				@ -8,4 +9,4 @@

				type Props = {

				  uri: string,

				  isResolvingUri: boolean,

				  totalItems: number,

neb-b (Migrated from github.com) commented

2018-10-21 20:27:36 +02:00

This should use the Claim type in types/claim

This should use the `Claim` type in `types/claim`

dannycalleri (Migrated from github.com) reviewed 2018-10-22 17:43:36 +02:00

src/renderer/component/channelTile/view.jsx

					
				@ -8,4 +9,4 @@

				type Props = {

				  uri: string,

				  isResolvingUri: boolean,

				  totalItems: number,

dannycalleri (Migrated from github.com) commented

2018-10-22 17:43:36 +02:00

Sorry, didn't notice that @seanyesmunt :)

dannycalleri (Migrated from github.com) reviewed 2018-10-22 17:44:01 +02:00

src/renderer/component/channelTile/view.jsx

					
				@ -8,4 +9,4 @@

				type Props = {

				  uri: string,

				  isResolvingUri: boolean,

				  totalItems: number,

dannycalleri (Migrated from github.com) commented

2018-10-22 17:44:01 +02:00

Changed 🤘

neb-b commented

2018-10-22 17:45:12 +02:00

(Migrated from github.com)

Thanks for the PR! Can we send you some LBC as appreciation?

Thanks for the PR! Can we [send you some LBC as appreciation](https://lbry.io/faq/appreciation)?

tzarebczan commented

2018-10-31 17:27:21 +01:00

(Migrated from github.com)

@dannycalleri If you'd like a Hacktoberfest t-shirt from LBRY, please reach out to us at the same address linked above!

Sign in to join this conversation.

No reviewers

neb-b

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2049