Linting errors fixable with --fix #2065

Open
opened 2018-10-28 16:19:05 +01:00 by amelzer · 2 comments
amelzer commented 2018-10-28 16:19:05 +01:00 (Migrated from github.com)

Currently, the project contains a ton of lint errors that get can and will get autofixed by running yarn lint . This adds several modified files to a commit / PR and therefore not helpful at the current stage.

The Issue

Steps to Reproduce

  1. Create new branch
  2. Run yarn flow
  3. Run git status

Expected Behaviour

No changes made, because master is clean of autifixable errors

Actual Behaviour

Tons of modified files

Suggested Solutions

My suggestion would be fixing each of those files in seperate PRs. One big PR would probably create a lot of merge conflicts for branches currently worked on. Modifying one of those files will prompt you to fix any other errors before commit. Might be a good time to do so :)

  • main/index.js
  • renderer/component/address/index.js
  • renderer/component/button/index.js
  • renderer/component/cardMedia/index.js
  • renderer/component/channelTile/index.js
  • renderer/component/common/credit-amount.jsx
  • renderer/component/common/file-exporter.jsx
  • renderer/component/dateTime/index.js
  • renderer/component/externalLink/index.js
  • renderer/component/fileActions/index.js
  • renderer/component/fileDetails/index.js
  • renderer/component/fileDetails/view.jsx
  • renderer/component/filePrice/index.js
  • renderer/component/formFieldPrice/index.js
  • renderer/component/nsfwOverlay/index.js
  • renderer/component/publishForm/index.js
  • renderer/component/router/index.js
  • renderer/component/selectChannel/index.js
  • renderer/component/shapeShift/index.js
  • renderer/component/snackBar/index.js
  • renderer/component/spinner/index.js
  • renderer/component/theme/index.js
  • renderer/component/transactionListRecent/index.js
  • renderer/component/uriIndicator/index.js
  • renderer/component/userVerify/view.jsx
  • renderer/component/walletAddress/index.js
  • renderer/component/walletBalance/index.js
  • renderer/component/walletSend/index.js
  • renderer/component/walletSendTip/index.js
  • renderer/modal/modalAffirmPurchase/index.js
  • renderer/modal/modalAuthFailure/index.js
  • renderer/modal/modalAutoUpdateConfirm/index.js
  • renderer/modal/modalAutoUpdateDownloaded/index.js
  • renderer/modal/modalConfirmTransaction/index.js
  • renderer/modal/modalError/index.js
  • renderer/modal/modalFileTimeout/index.js
  • renderer/modal/modalFirstSubscription/index.js
  • renderer/modal/modalIncompatibleDaemon/index.js
  • renderer/modal/modalOpenExternalLink/index.js
  • renderer/modal/modalPublish/index.js
  • renderer/modal/modalRemoveFile/index.js
  • renderer/modal/modalRevokeClaim/index.js
  • renderer/modal/modalRewardApprovalRequired/index.js
  • renderer/modal/modalSendTip/index.js
  • renderer/modal/modalTransactionFailed/index.js
  • renderer/modal/modalWelcome/index.js
  • renderer/page/backup/index.js
  • renderer/page/getCredits/index.js
  • renderer/page/report/index.js
  • renderer/page/sendCredits/index.js
  • renderer/page/show/index.js
  • renderer/page/transactionHistory/index.js
  • renderer/page/userHistory/index.js
  • renderer/page/wallet/index.js
  • renderer/redux/reducers/shape_shift.js
  • renderer/redux/selectors/content.js

System Configuration

Not important. Can be done without actually running the project.

Acceptance Criteria

  1. Files don't get modified by yarn lint on a fresh branch
Currently, the project contains a ton of lint errors that get can and will get autofixed by running `yarn lint` . This adds several modified files to a commit / PR and therefore not helpful at the current stage. ## The Issue ### Steps to Reproduce 1. Create new branch 2. Run `yarn flow` 3. Run `git status` ### Expected Behaviour No changes made, because master is clean of autifixable errors ### Actual Behaviour Tons of modified files ### Suggested Solutions My suggestion would be fixing each of those files in seperate PRs. One big PR would probably create a lot of merge conflicts for branches currently worked on. Modifying one of those files will prompt you to fix any other errors before commit. Might be a good time to do so :) - [ ] main/index.js - [x] renderer/component/address/index.js - [x] renderer/component/button/index.js - [ ] renderer/component/cardMedia/index.js - [x] renderer/component/channelTile/index.js - [x] renderer/component/common/credit-amount.jsx - [ ] renderer/component/common/file-exporter.jsx - [x] renderer/component/dateTime/index.js - [x] renderer/component/externalLink/index.js - [x] renderer/component/fileActions/index.js - [x] renderer/component/fileDetails/index.js - [ ] renderer/component/fileDetails/view.jsx - [x] renderer/component/filePrice/index.js - [ ] renderer/component/formFieldPrice/index.js - [x] renderer/component/nsfwOverlay/index.js - [ ] renderer/component/publishForm/index.js - [x] renderer/component/router/index.js - [ ] renderer/component/selectChannel/index.js - [x] renderer/component/shapeShift/index.js - [x] renderer/component/snackBar/index.js - [x] renderer/component/spinner/index.js - [ ] renderer/component/theme/index.js - [x] renderer/component/transactionListRecent/index.js - [x] renderer/component/uriIndicator/index.js - [ ] renderer/component/userVerify/view.jsx - [x] renderer/component/walletAddress/index.js - [x] renderer/component/walletBalance/index.js - [x] renderer/component/walletSend/index.js - [ ] renderer/component/walletSendTip/index.js - [ ] renderer/modal/modalAffirmPurchase/index.js - [ ] renderer/modal/modalAuthFailure/index.js - [ ] renderer/modal/modalAutoUpdateConfirm/index.js - [ ] renderer/modal/modalAutoUpdateDownloaded/index.js - [ ] renderer/modal/modalConfirmTransaction/index.js - [ ] renderer/modal/modalError/index.js - [ ] renderer/modal/modalFileTimeout/index.js - [ ] renderer/modal/modalFirstSubscription/index.js - [ ] renderer/modal/modalIncompatibleDaemon/index.js - [ ] renderer/modal/modalOpenExternalLink/index.js - [ ] renderer/modal/modalPublish/index.js - [ ] renderer/modal/modalRemoveFile/index.js - [ ] renderer/modal/modalRevokeClaim/index.js - [ ] renderer/modal/modalRewardApprovalRequired/index.js - [ ] renderer/modal/modalSendTip/index.js - [ ] renderer/modal/modalTransactionFailed/index.js - [ ] renderer/modal/modalWelcome/index.js - [ ] renderer/page/backup/index.js - [ ] renderer/page/getCredits/index.js - [ ] renderer/page/report/index.js - [ ] renderer/page/sendCredits/index.js - [ ] renderer/page/show/index.js - [ ] renderer/page/transactionHistory/index.js - [ ] renderer/page/userHistory/index.js - [ ] renderer/page/wallet/index.js - [ ] renderer/redux/reducers/shape_shift.js - [ ] renderer/redux/selectors/content.js ## System Configuration Not important. Can be done without actually running the project. ### Acceptance Criteria 1. Files don't get modified by `yarn lint` on a fresh branch
neb-b commented 2018-10-28 22:33:20 +01:00 (Migrated from github.com)

This is great @amelzer

We have been slowly fixing files as we work on them, but it's good to have one complete list of all of the files with issues.

This is great @amelzer We have been slowly fixing files as we work on them, but it's good to have one complete list of all of the files with issues.
Borewit commented 2019-09-01 13:32:57 +02:00 (Migrated from github.com)

Some lint errors are hard to fix due to ebpack-preprocessor-loader, more info: https://www.npmjs.com/package/webpack-preprocessor-loader#eslint

Some lint errors are hard to fix due to ebpack-preprocessor-loader, more info: https://www.npmjs.com/package/webpack-preprocessor-loader#eslint
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2065
No description provided.