Move modals back to the app, use doToast for toasts in prep for notifications v2 #2068

Merged
neb-b merged 3 commits from notifications into master 2018-11-20 17:46:46 +01:00
neb-b commented 2018-10-29 18:16:05 +01:00 (Migrated from github.com)

Still testing this.

Relies on https://github.com/lbryio/lbry-redux/pull/93

Still testing this. Relies on https://github.com/lbryio/lbry-redux/pull/93
skhameneh (Migrated from github.com) reviewed 2018-10-30 19:26:16 +01:00
skhameneh (Migrated from github.com) commented 2018-10-30 19:26:10 +01:00

Should use a switch or an key/value object with react classes in it.

Should use a switch or an key/value object with react classes in it.
skhameneh (Migrated from github.com) reviewed 2018-10-30 19:26:55 +01:00
skhameneh (Migrated from github.com) commented 2018-10-30 19:26:55 +01:00

Not for all, but for notifications it would be nice

Not for all, but for notifications it would be nice
neb-b commented 2018-11-16 06:34:35 +01:00 (Migrated from github.com)

@skhameneh Still need a review on this one. The few conflicts are from new modals/snackbars that have been added. I'll move those over to use the new notification logic.

@skhameneh Still need a review on this one. The few conflicts are from new modals/snackbars that have been added. I'll move those over to use the new notification logic.
skhameneh (Migrated from github.com) approved these changes 2018-11-20 17:18:53 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2068
No description provided.