Fix to open folder containing the log file rather than roaming folder #2078

Merged

dyllper merged 3 commits from fix/open-log-folder into master

2018-10-31 17:26:17 +01:00

dyllper commented

2018-10-31 07:51:13 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

[ x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ x ] I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

[ x ] Bugfix
Feature
Breaking changes (bugfix or feature that introduces breaking changes)
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1600

What is the current behavior?

Clicking "Open Log Folder" will open the "lbry" folder with "lbrynet" highlighted, rather than opening the "lbrynet" folder which contains the log file.

What is the new behavior?

Clicking "Open Log Folder" will open the "lbrynet" folder that contains the log file.

Other information

## PR Checklist Please check all that apply to this PR using "x": - [ x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ x ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce?  - [ x ] Bugfix - [ ] Feature - [ ] Breaking changes (bugfix or feature that introduces breaking changes) - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1600 ## What is the current behavior? Clicking "Open Log Folder" will open the "lbry" folder with "lbrynet" highlighted, rather than opening the "lbrynet" folder which contains the log file. ## What is the new behavior? Clicking "Open Log Folder" will open the "lbrynet" folder that contains the log file. ## Other information

🎉 1

neb-b (Migrated from github.com) reviewed 2018-10-31 07:51:13 +01:00

tzarebczan commented

2018-10-31 16:07:11 +01:00

(Migrated from github.com)

hey @dyllper, thanks for submitting this PR! We'll have someone review it shortly. Can you also add a changelog entry for this (see previous entries for format).

Make sure to check out our contributing document.

Once this is merged, can we send you some LBC as appreciation?

hey @dyllper, thanks for submitting this PR! We'll have someone review it shortly. Can you also add a changelog entry for this (see previous entries for format). Make sure to check out our [contributing document](https://github.com/lbryio/lbry-desktop/blob/master/CONTRIBUTING.md). Once this is merged, can we send you [some LBC as appreciation](https://lbry.io/faq/appreciation)?

dyllper commented

2018-10-31 17:14:16 +01:00

(Migrated from github.com)

@tzarebczan Updated the Changelog! Sorry about that. Missed that section when I was reading through the CONTRIBUTING.md file.

Thank you for the offer of LBC, but that won't be necessary. Just happy to be able to help out!

@tzarebczan Updated the Changelog! Sorry about that. Missed that section when I was reading through the CONTRIBUTING.md file. Thank you for the offer of LBC, but that won't be necessary. Just happy to be able to help out!

👍 1

tzarebczan commented

2018-10-31 17:16:38 +01:00

(Migrated from github.com)

@dyllper how about a Hacktoberfest t-shirt from LBRY? Just reach out to us at the same address :)

neb-b commented

2018-10-31 17:26:09 +01:00

(Migrated from github.com)

Tested and working good! Thanks @dyllper 🙂