Rc fixes #2082

2018-10-31T18:39:07+01:00

neb-b commented

2018-10-31 18:39:07 +01:00

(Migrated from github.com)

More fixes for the RC
https://github.com/lbryio/lbry-desktop/issues/2073

Added subscription icons to the home page
Fixed channel subscribe failing on the channel page
Fixed channel creation failing by changing the bid amount to a string
Fixed dark mode markdown editor

More fixes for the RC https://github.com/lbryio/lbry-desktop/issues/2073 - Added subscription icons to the home page - Fixed channel subscribe failing on the channel page - Fixed channel creation failing by changing the bid amount to a string - Fixed dark mode markdown editor

neb-b (Migrated from github.com) reviewed 2018-10-31 18:40:10 +01:00

.eslintrc.json

					
				@ -45,2 +45,3 @@

				    "jsx-a11y/click-events-have-key-events": 0

				    "jsx-a11y/click-events-have-key-events": 0,

				    "consistent-return": 0

				  }

neb-b (Migrated from github.com) commented

2018-10-31 18:40:10 +01:00

This has always caused issues, mainly in react components where you might not want to return anything:
ex:

someMethod() {
  if (!props.value) return;
  
  doStuff()
}

This has always caused issues, mainly in react components where you might not want to return anything: ex: ``` someMethod() { if (!props.value) return; doStuff() } ```