Comments support button #2095

2018-11-07T23:19:24+01:00

neb-b commented

2018-11-07 23:19:24 +01:00

(Migrated from github.com)

Changes

Adds a button that will register support for adding comments in the app
Adds <Expandable> component

Still deciding on the copy for button/message

### Changes - Adds a button that will register support for adding comments in the app - Adds `<Expandable>` component Still deciding on the copy for button/message

neb-b (Migrated from github.com) reviewed 2018-11-07 23:22:19 +01:00

src/renderer/constants/action_types.js

neb-b (Migrated from github.com) commented

2018-11-07 23:22:18 +01:00

This was added to the lbry-redux action types but it should have never been there. I will do some cleanup in the future to make sure we aren't keeping types there that only belong in the app

skhameneh (Migrated from github.com) approved these changes 2018-11-14 01:41:33 +01:00

src/renderer/component/expandable/index.js

					
				@ -0,0 +1,7 @@

				import { connect } from 'react-redux';

				import Expandable from './view';

				export default connect(

skhameneh (Migrated from github.com) commented

2018-11-14 01:37:14 +01:00

😐

src/renderer/component/expandable/view.jsx

					
				@ -0,0 +19,4 @@

				  constructor() {

				    super();

				    this.state = {

skhameneh (Migrated from github.com) commented

2018-11-14 01:39:37 +01:00

Can also do:

class MyComponent extends PureComponent {
  state = {};
}

and use arrow fn's or bind syntax https://babeljs.io/blog/2015/05/14/function-bind

Can also do: ``` class MyComponent extends PureComponent { state = {}; } ``` and use arrow fn's or bind syntax https://babeljs.io/blog/2015/05/14/function-bind

src/renderer/component/fileDetails/view.jsx

					
				@ -45,0 +81,4 @@

				              {': '}

				              {language}

				            </div>

				            <div>

skhameneh (Migrated from github.com) commented

2018-11-14 01:40:42 +01:00

Should 'unknown' be a shared constant?

Should `'unknown'` be a shared constant?

neb-b (Migrated from github.com) reviewed 2018-11-14 01:54:15 +01:00

src/renderer/component/fileDetails/view.jsx

					
				@ -45,0 +81,4 @@

				              {': '}

				              {language}

				            </div>

				            <div>

neb-b (Migrated from github.com) commented

2018-11-14 01:54:14 +01:00

Probably. Although I'm not sure where else it's used.

Sign in to join this conversation.

No reviewers

skhameneh

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2095