LBRYCommunity/lbry-desktop

Show recommended subscriptions #2109

Merged

neb-b merged 2 commits from subscriptions into master

2018-11-27 17:23:39 +01:00

neb-b commented

2018-11-16 06:49:17 +01:00

(Migrated from github.com)

PR Type

Bugfix
Feature
Breaking changes (bugfix or feature that introduces breaking changes)
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1825

What is the current behavior?

We don't recommend any channels for subscriptions

What is the new behavior?

Channels are recommended on your first run, if you clear out all of you unread subscriptions, and if you unsubscribe from all of the channels you originally subscribed too.

Additional changes

Cleaned up the util/ folder. Now all files use the same naming convenstions file-name.js
Split the subscriptions page into sub components, it was starting to get very big.

## PR Type  - [ ] Bugfix - [x] Feature - [ ] Breaking changes (bugfix or feature that introduces breaking changes) - [x] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1825 ## What is the current behavior? We don't recommend any channels for subscriptions ## What is the new behavior? Channels are recommended on your first run, if you clear out all of you unread subscriptions, and if you unsubscribe from all of the channels you originally subscribed too. ## Additional changes - Cleaned up the `util/` folder. Now all files use the same naming convenstions `file-name.js` - Split the subscriptions page into sub components, it was starting to get very big.

neb-b (Migrated from github.com) reviewed 2018-11-16 06:53:51 +01:00

src/renderer/component/subscribeButton/view.jsx

					
				@ -36,1 +41,3 @@

				  return channelName && uri ? (

				  const { claimName } = parseURI(uri);

				  return (

neb-b (Migrated from github.com) commented

2018-11-16 06:53:51 +01:00

Before we were passing the uri and the channel name in, but we can just get the channel name from the uri

Before we were passing the uri and the channel name in, but we can just get the channel name from the uri

skhameneh (Migrated from github.com) approved these changes 2018-11-26 23:35:54 +01:00

src/renderer/component/subscribeButton/view.jsx

skhameneh (Migrated from github.com) commented

2018-11-26 23:33:21 +01:00

I would suggest moving this logic out of the inline markup

I would suggest moving this logic out of the inline markup

src/renderer/store.js

skhameneh (Migrated from github.com) commented

2018-11-26 23:35:13 +01:00

Why the change in formatting?
*Mostly curious

Why the change in formatting? *Mostly curious

neb-b (Migrated from github.com) reviewed 2018-11-27 16:58:44 +01:00

src/renderer/store.js

neb-b (Migrated from github.com) commented

2018-11-27 16:58:44 +01:00

I removed the subscriptionsFilter so prettier decided it could all be on one line

I removed the `subscriptionsFilter` so prettier decided it could all be on one line

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2109

No description provided.