LBRYCommunity/lbry-desktop

Pressing escape in wunderbar should do something useful #2116

New issue

Closed

opened 2018-11-21 17:52:48 +01:00 by jessopb · 6 comments

jessopb commented

2018-11-21 17:52:48 +01:00

(Migrated from github.com)

The Issue

When I click in wunderbar which is displaying current location (perhaps to copy or edit), if I start typing, or searching and don't like my progress, escape does nothing.

Steps to Reproduce

Start searching.
Press escape. Nothing happens.
???

Expected Behaviour

Tell us what should happen.
Pressing escape should clear, then reset to fully selected current location.

Actual Behaviour

When pressing escape, nothing happens at all.

System Configuration

App	0.25.1
Daemon (lbrynet)	0.21.2
Wallet (lbryum)	3.2.4
Connected Email	jessopb@gmail.com
Reward Eligible	Yes
Platform	Linux (Linux-4.15.0-38-generic-x86_64-with-Ubuntu-18.04-bionic)

## The Issue When I click in wunderbar which is displaying current location (perhaps to copy or edit), if I start typing, or searching and don't like my progress, escape does nothing. ### Steps to Reproduce 1. Start searching. 2. Press escape. Nothing happens. 3. ??? ### Expected Behaviour Tell us what should happen. Pressing escape should clear, then reset to fully selected current location. ### Actual Behaviour When pressing escape, nothing happens at all. ## System Configuration App | 0.25.1 -- | -- Daemon (lbrynet) | 0.21.2 Wallet (lbryum) | 3.2.4 Connected Email | jessopb@gmail.com Reward Eligible | Yes Platform | Linux (Linux-4.15.0-38-generic-x86_64-with-Ubuntu-18.04-bionic)

neb-b commented

2018-11-21 18:16:29 +01:00

(Migrated from github.com)

This is a great idea. I agree with the expected behavior, that is the same way chrome handles the escape key.

This is a great idea. I agree with the expected behavior, that is the same way chrome handles the escape key.

adamflitney commented

2019-10-15 22:39:05 +02:00

(Migrated from github.com)

Could I have a go at this?

Could I have a go at this?

tzarebczan commented

2019-10-15 22:48:02 +02:00

(Migrated from github.com)

@adamflitney she's all yours! Added the Hacktoberfest label also.

@adamflitney she's all yours! Added the Hacktoberfest label also.

luckymurari commented

2019-10-26 17:25:49 +02:00

(Migrated from github.com)

@adamflitney Are you working on this? If not, shall I have a go at this?

@adamflitney Are you working on this? If not, shall I have a go at this?

adamflitney commented

2019-10-26 20:59:52 +02:00

(Migrated from github.com)

@luckymurari I was planning on doing it, but life got a bit busy. Happy for you to have a go rather than it be left for a while. :)

@luckymurari I was planning on doing it, but life got a bit busy. Happy for you to have a go rather than it be left for a while. :)

jessopb commented

2021-10-04 23:56:10 +02:00

(Migrated from github.com)

ce7be7229b merged

https://github.com/lbryio/lbry-desktop/commit/ce7be7229bbbcfa6812a8e6400d78d9920501ece merged

Sign in to join this conversation.

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2116

No description provided.