fetch subs fix #2130

Merged
tzarebczan merged 1 commit from fix-fetch into master 2018-11-30 20:54:59 +01:00
tzarebczan commented 2018-11-30 20:00:59 +01:00 (Migrated from github.com)

Instead of calling check subscriptions after fetching them (with a timeout hack), do this directly in the fetch routine instead of calling claim_list_by_channel. This ensures claim_list_by_channel is only called once and the subscriptions are checked after every fetch.

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: N/A

What is the current behavior?

What is the new behavior?

Other information

Instead of calling check subscriptions after fetching them (with a timeout hack), do this directly in the fetch routine instead of calling claim_list_by_channel. This ensures claim_list_by_channel is only called once and the subscriptions are checked after every fetch. ## PR Checklist Please check all that apply to this PR using "x": - [ ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? <!-- Please check all that apply to this PR using "x". --> - [ ] Bugfix - [ ] Feature - [ ] Breaking changes (bugfix or feature that introduces breaking changes) - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: N/A ## What is the current behavior? ## What is the new behavior? ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
neb-b (Migrated from github.com) reviewed 2018-11-30 20:00:59 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2130
No description provided.